Address CR: Move state.error messages from ui to console

near · Oct 11, 2023 · 8e36bc7 · 8e36bc7
1 parent 4ad87e2
commit 8e36bc7
Show file tree

Hide file tree

Showing 4 changed files with 16 additions and 4 deletions.
diff --git a/src/Recommender/Service/RecommendedUsers.jsx b/src/Recommender/Service/RecommendedUsers.jsx
@@ -129,6 +129,10 @@ if (state.isLoading) {
   getRecommendedUsers(state.currentPage);
 }
 
+if (state.error) {
+  console.error("Error, try again later", state.error);
+}
+
 const handleFollowed = (accountId) => {
   const updatedUsers = state.displayedUsers.filter(
     (user) => (user.recommended_profile || user.similar_profile) !== accountId
@@ -141,7 +145,6 @@ const handleFollowed = (accountId) => {
 return (
   <RecommendedUsers>
     {state.isLoading && <p>Loading...</p>}
-    {state.error && <p>Error: {state.error}</p>}
     <Profiles>
       {!state.isLoading && state.displayedUsers.length < 4 ? (
         <>

diff --git a/src/Recommender/Views/FriendsOfFriends.jsx b/src/Recommender/Views/FriendsOfFriends.jsx
@@ -115,10 +115,13 @@ if (state.isLoading) {
   getRecommendedUsers(state.currentPage);
 }
 
+if (state.error) {
+  console.error("Error, try again later", state.error);
+}
+
 return (
   <RecommendedUsers>
     {state.isLoading && <p>Loading...</p>}
-    {state.error && <p>Error: {state.error}</p>}
     <Profiles>
       {!state.isLoading && displayedUsers.length < 4 ? (
         <>

diff --git a/src/Recommender/Views/SimilarProfiles.jsx b/src/Recommender/Views/SimilarProfiles.jsx
@@ -123,10 +123,13 @@ if (state.isLoading) {
   getRecommendedUsers(state.currentPage);
 }
 
+if (state.error) {
+  console.error("Error, try again later", state.error);
+}
+
 return (
   <RecommendedUsers>
     {state.isLoading && <p>Loading...</p>}
-    {state.error && <p>Error: {state.error}</p>}
     <Profiles>
       {!state.isLoading && displayedUsers.length < 4 ? (
         <>

diff --git a/src/Recommender/Views/TrendingUsersView.jsx b/src/Recommender/Views/TrendingUsersView.jsx
@@ -115,10 +115,13 @@ if (state.isLoading) {
   getRecommendedUsers(state.currentPage);
 }
 
+if (state.error) {
+  console.error("Error, try again later", state.error);
+}
+
 return (
   <RecommendedUsers>
     {state.isLoading && displayedUsers.length == null && <p>Loading...</p>}
-    {state.error && <p>Error: {state.error}</p>}
     {(displayedUsers.length < 4 || displayedUsers == null) &&
       state.isLoading &&
       (props.scope == "friends" || props.scope === "similar") && (