feat(mocknet): change HTTP request logic #10023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We'll change things to bind to "localhost" instead of "0.0.0.0", and make HTTP requests by SSH + curl on the remote server. It's also possible to set up an explicit SSH/SOCKS proxy, but that would require one for each server and would be long-lived, which might be a bit annoying for people running the test scripts
Ekleog-NEAR
reviewed
Oct 27, 2023
There was a problem hiding this comment.
Security-wise this seems good. I just submitted a comment for an issue I saw, I’ll let @wacban make the call on whether, from a code standpoint, this approach is the best one :)
| 'jsonrpc': '2.0' | ||
| } | ||
| body = json.dumps(body) | ||
| r = run_cmd(node, f'curl localhost:3000 -d \'{body}\'') |
There was a problem hiding this comment.
Not sure if that’s important? but here if method or params contain a quote, then this will fail. Might need to replace all ' in body with '"'"' first
There was a problem hiding this comment.
I would feel slightly better with some escaping provided by a library but as long as this works it's ok.
wacban
approved these changes
Oct 30, 2023
| 'jsonrpc': '2.0' | ||
| } | ||
| body = json.dumps(body) | ||
| r = run_cmd(node, f'curl localhost:3000 -d \'{body}\'') |
There was a problem hiding this comment.
I would feel slightly better with some escaping provided by a library but as long as this works it's ok.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We'll change things to bind to "localhost" instead of "0.0.0.0", and make HTTP requests by SSH + curl on the remote server. It's also possible to set up an explicit SSH/SOCKS proxy, but that would require one for each server and would be long-lived, which might be a bit annoying for people running the test scripts