-
Notifications
You must be signed in to change notification settings - Fork 664
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate AnnounceAccounts #10024
Deprecate AnnounceAccounts #10024
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've confirmed that AccountsData is no longer of use.
Did you mean “AnnounceAccounts
is no longer of use”?
Seems quite nice otherwise!
Thanks, yes, updated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Restamping
This reverts commit 5f942be.
This reverts commit 5f942be.
This reverts commit 5f942be.
This reverts commit 5f942be in order to fix some integration tests. x "pytest sanity/network_drop_package.py --features nightly", "pytest sanity/network_drop_package.py", x "pytest sanity/proxy_restart.py --features nightly", "pytest sanity/proxy_restart.py", x "pytest sanity/proxy_simple.py --features nightly", "pytest sanity/proxy_simple.py", x "pytest sanity/restart.py --features nightly",---Jan "pytest sanity/restart.py",---Jan x "pytest sanity/sync_ban.py false --features nightly", "pytest sanity/sync_ban.py false", "expensive integration-tests integration_tests tests::client::block_corruption::check_process_flipped_block_fails --features nightly", "expensive integration-tests integration_tests tests::client::block_corruption::check_process_flipped_block_fails" "expensive integration-tests integration_tests
AnnounceAccounts is a legacy mechanism supporting Validator AccountId -> PeerId lookups. It was superseded by AccountsData about a year ago and has been awaiting deprecation:
nearcore/chain/network/src/peer_manager/network_state/mod.rs
Lines 596 to 606 in 7c0b58f
By inspecting the
ACCOUNT_TO_PEER_LOOKUPS
metric for several mainnet validators, I've confirmed that AnnounceAccounts is no longer of use. Additionally, enough release versions have passed since the introduction of AccountsData that we can get rid of AnnounceAccounts entirely at this point (see #8182).This PR removes all of the client code which has to do with creation and usage of AnnounceAccounts. I plan to send separate PRs removing related fields/types from the network message protocol and deprecating
DBCol::AccountAnnouncements
(as this PR is large enough already).