Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hack: experimental chunk execution #12013

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

pugachAG
Copy link
Contributor

This PR executes apply_chunk with ApplyChunkReason::Experiment along with the normal execution with ApplyChunkReason::UpdateTrackedShard. This way we can modify runtime behaviour based on apply_state.apply_reason and compare the metrics we are interested in.

Copy link

codecov bot commented Aug 28, 2024

Codecov Report

Attention: Patch coverage is 96.42857% with 1 line in your changes missing coverage. Please review.

Project coverage is 71.53%. Comparing base (ee5f317) to head (117ee0e).
Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
tools/replay-archive/src/cli.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #12013      +/-   ##
==========================================
+ Coverage   71.51%   71.53%   +0.02%     
==========================================
  Files         812      814       +2     
  Lines      164491   164652     +161     
  Branches   164491   164652     +161     
==========================================
+ Hits       117634   117790     +156     
+ Misses      41701    41699       -2     
- Partials     5156     5163       +7     
Flag Coverage Δ
backward-compatibility 0.23% <0.00%> (-0.01%) ⬇️
db-migration 0.23% <0.00%> (-0.01%) ⬇️
genesis-check 1.34% <0.00%> (-0.01%) ⬇️
integration-tests 38.48% <96.42%> (+0.05%) ⬆️
linux 71.22% <96.42%> (-0.05%) ⬇️
linux-nightly 71.09% <96.42%> (-0.01%) ⬇️
macos 54.18% <75.00%> (+0.59%) ⬆️
pytests 1.60% <0.00%> (-0.01%) ⬇️
sanity-checks 1.40% <0.00%> (-0.01%) ⬇️
unittests 65.48% <96.42%> (+0.02%) ⬆️
upgradability 0.27% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pugachAG pugachAG force-pushed the shadow-validation-increase-soft-limit branch 7 times, most recently from aac57bc to 16d1b4e Compare August 29, 2024 10:32
@pugachAG pugachAG force-pushed the shadow-validation-increase-soft-limit branch from 16d1b4e to e46392c Compare August 29, 2024 10:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant