Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update compact-database command to enable compacting cold storage #12094

Closed
wants to merge 7 commits into from

Conversation

tayfunelmas
Copy link
Contributor

@tayfunelmas tayfunelmas commented Sep 16, 2024

Current neard database compact-database command runs compaction on Hot db by default.

We add an option to run compaction on cold db. We will also use this to run some experiments on cleaning up data in cold storage followed-up with compaction.

The command continues to run on Hot DB by default and cold storage is only enabled by adding a -t cold flag.

Also change utils to use DBOpener to fix a bug about not opening the right db path (previously home directory path was not joined with the db directory name).

Copy link

codecov bot commented Sep 16, 2024

Codecov Report

Attention: Patch coverage is 23.07692% with 20 lines in your changes missing coverage. Please review.

Project coverage is 71.82%. Comparing base (3d46ee4) to head (5c5d00a).
Report is 134 commits behind head on master.

Files with missing lines Patch % Lines
tools/database/src/utils.rs 0.00% 16 Missing ⚠️
tools/database/src/compact.rs 0.00% 4 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##           master   #12094   +/-   ##
=======================================
  Coverage   71.82%   71.82%           
=======================================
  Files         827      827           
  Lines      166626   166646   +20     
  Branches   166626   166646   +20     
=======================================
+ Hits       119681   119696   +15     
- Misses      41728    41734    +6     
+ Partials     5217     5216    -1     
Flag Coverage Δ
backward-compatibility 0.17% <0.00%> (-0.01%) ⬇️
db-migration 0.17% <0.00%> (-0.01%) ⬇️
genesis-check 1.25% <0.00%> (-0.01%) ⬇️
integration-tests 38.77% <23.07%> (+0.01%) ⬆️
linux 71.51% <23.07%> (-0.01%) ⬇️
linux-nightly 71.40% <23.07%> (+<0.01%) ⬆️
macos 54.53% <23.07%> (-0.07%) ⬇️
pytests 1.57% <0.00%> (-0.01%) ⬇️
sanity-checks 1.37% <0.00%> (-0.01%) ⬇️
unittests 65.63% <23.07%> (-0.01%) ⬇️
upgradability 0.21% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tayfunelmas tayfunelmas marked this pull request as ready for review September 17, 2024 08:30
@tayfunelmas tayfunelmas requested a review from a team as a code owner September 17, 2024 08:30
@tayfunelmas tayfunelmas closed this by deleting the head repository Nov 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant