Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(state-sync): sync to the current epoch instead of the previous #12102

Merged
merged 75 commits into from
Oct 26, 2024

Commits on Sep 17, 2024

  1. Configuration menu
    Copy the full SHA
    ad4d1d1 View commit details
    Browse the repository at this point in the history
  2. change var names

    marcelo-gonzalez committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    76f9350 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    a445393 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    174b62f View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    a59e594 View commit details
    Browse the repository at this point in the history
  6. state sync to the current epoch during catchup

    this just implements the requester side of things, and does not work
    because there is no support in the state dumper for this. But it sets up
    all the logic to request state headers and parts in the new way
    marcelo-gonzalez committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    f8f6fb6 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    f4eba89 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    53e933c View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    5c9055f View commit details
    Browse the repository at this point in the history
  10. add TODOs

    marcelo-gonzalez committed Sep 17, 2024
    Configuration menu
    Copy the full SHA
    281c156 View commit details
    Browse the repository at this point in the history

Commits on Sep 18, 2024

  1. Configuration menu
    Copy the full SHA
    386df33 View commit details
    Browse the repository at this point in the history

Commits on Sep 24, 2024

  1. Configuration menu
    Copy the full SHA
    df90eb0 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2eda311 View commit details
    Browse the repository at this point in the history
  3. comments

    marcelo-gonzalez committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    5900d8c View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    8dea6ad View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    78610c7 View commit details
    Browse the repository at this point in the history
  6. add TODO

    marcelo-gonzalez committed Sep 24, 2024
    Configuration menu
    Copy the full SHA
    e5d428e View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    2379aec View commit details
    Browse the repository at this point in the history

Commits on Oct 2, 2024

  1. Configuration menu
    Copy the full SHA
    5e2f654 View commit details
    Browse the repository at this point in the history

Commits on Oct 3, 2024

  1. Configuration menu
    Copy the full SHA
    4e9195a View commit details
    Browse the repository at this point in the history
  2. update comment :)

    marcelo-gonzalez committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    78d6a75 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    f07977a View commit details
    Browse the repository at this point in the history
  4. remove comment

    marcelo-gonzalez committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    135921d View commit details
    Browse the repository at this point in the history
  5. fix test

    marcelo-gonzalez committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    15d707b View commit details
    Browse the repository at this point in the history
  6. nit

    marcelo-gonzalez committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    776de8f View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2024

  1. Configuration menu
    Copy the full SHA
    9ae019a View commit details
    Browse the repository at this point in the history

Commits on Oct 15, 2024

  1. Configuration menu
    Copy the full SHA
    e4649ec View commit details
    Browse the repository at this point in the history
  2. sync the new way when state syncing due to being behind the chain rat…

    …her than catching up for chunk production
    marcelo-gonzalez committed Oct 15, 2024
    Configuration menu
    Copy the full SHA
    7f42d30 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    abb174d View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    e8e9f35 View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2024

  1. Configuration menu
    Copy the full SHA
    b45cff1 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f6d860f View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    8c58ee5 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    6fa6c3c View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    7be8679 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    80174d5 View commit details
    Browse the repository at this point in the history

Commits on Oct 18, 2024

  1. Configuration menu
    Copy the full SHA
    97d3abc View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2024

  1. Configuration menu
    Copy the full SHA
    3566cd0 View commit details
    Browse the repository at this point in the history
  2. delete comment

    marcelo-gonzalez committed Oct 21, 2024
    Configuration menu
    Copy the full SHA
    105257e View commit details
    Browse the repository at this point in the history

Commits on Oct 22, 2024

  1. don't pass block header to should_make_or_delete_snapshot()

    This makes it simpler overall. Also refactor this function to return
    an enum saying what to do instead of two bools, which was a little
    bit confusing before.
    marcelo-gonzalez committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    c008b90 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    89bc547 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    1b81f8c View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    1c10b15 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    18d3623 View commit details
    Browse the repository at this point in the history
  6. comments

    marcelo-gonzalez committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    eb88ad3 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    7be1c8a View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    7902bb7 View commit details
    Browse the repository at this point in the history
  9. consolidate calls to get_current_epoch_sync_hash() and get_epoch_star…

    …t_sync_hash()
    
    make this just one get_sync_hash() with the protocol feature logic in there, and
    make the other two private
    marcelo-gonzalez committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    7dbf812 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    741862b View commit details
    Browse the repository at this point in the history
  11. move find_sync_hash() back to the ClientActor

    this was moved to the Client so we could call it in tests in 9ae019a
    but now that we have a Chain::get_sync_hash() function, this is no longer needed
    marcelo-gonzalez committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    3176a89 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    6c645ed View commit details
    Browse the repository at this point in the history
  13. Configuration menu
    Copy the full SHA
    f96f762 View commit details
    Browse the repository at this point in the history
  14. Configuration menu
    Copy the full SHA
    0628634 View commit details
    Browse the repository at this point in the history
  15. add another enum variant to StateSyncInfo for the new version

    previous epoch -> V0
    current epoch -> V1
    marcelo-gonzalez committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    7d903ec View commit details
    Browse the repository at this point in the history
  16. rename StateSyncInfo::block_hash() -> StateSyncInfo::epoch_first_block()

    more clear what is being talked about
    marcelo-gonzalez committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    ba3397a View commit details
    Browse the repository at this point in the history
  17. add comments

    marcelo-gonzalez committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    78497d4 View commit details
    Browse the repository at this point in the history
  18. match nit

    marcelo-gonzalez committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    98b6f6d View commit details
    Browse the repository at this point in the history
  19. Configuration menu
    Copy the full SHA
    f4d4866 View commit details
    Browse the repository at this point in the history
  20. Configuration menu
    Copy the full SHA
    dc8e3db View commit details
    Browse the repository at this point in the history
  21. FIXME -> TODO

    marcelo-gonzalez committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    0f79f7f View commit details
    Browse the repository at this point in the history
  22. match nit

    marcelo-gonzalez committed Oct 22, 2024
    Configuration menu
    Copy the full SHA
    c48db12 View commit details
    Browse the repository at this point in the history

Commits on Oct 23, 2024

  1. Configuration menu
    Copy the full SHA
    3c575f7 View commit details
    Browse the repository at this point in the history
  2. nits

    marcelo-gonzalez committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    720e2c5 View commit details
    Browse the repository at this point in the history
  3. add TODO

    marcelo-gonzalez committed Oct 23, 2024
    Configuration menu
    Copy the full SHA
    920156a View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    ded0a8e View commit details
    Browse the repository at this point in the history

Commits on Oct 24, 2024

  1. migrate test_state_request to test loop

    This test fails because the mock epoch manager does not implement
    get_block_info(), which is needed in the new implementation of get_sync_hash().
    Instead of trying to fix it, just move the test to test loop
    marcelo-gonzalez committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    db3e2cb View commit details
    Browse the repository at this point in the history
  2. return None in get_sync_hash() for the genesis block

    Otherwise this might return an error when looking up the prev header
    in get_current_epoch_sync_hash(), and we don't want to sync state from
    before the genesis anyway
    marcelo-gonzalez committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    9991c89 View commit details
    Browse the repository at this point in the history
  3. Don't call check_sync_hash_validity() for the genesis block in test_s…

    …ync_hash_validity()
    
    The behavior has changed to return false for the genesis block, but getting the sync hash corresponding
    to the genesis block is not something we ever want to do, since we're not going to be syncing that state,
    and there's an assertion that checks we dont use the genesis hash as a sync hash in ClientActorInner::find_sync_hash()
    anyway.
    marcelo-gonzalez committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    99f98a5 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    66f30f1 View commit details
    Browse the repository at this point in the history
  5. rm unused uses

    marcelo-gonzalez committed Oct 24, 2024
    Configuration menu
    Copy the full SHA
    902e90a View commit details
    Browse the repository at this point in the history

Commits on Oct 25, 2024

  1. Configuration menu
    Copy the full SHA
    752f9e8 View commit details
    Browse the repository at this point in the history

Commits on Oct 26, 2024

  1. Configuration menu
    Copy the full SHA
    598f49c View commit details
    Browse the repository at this point in the history
  2. fix state_parts_dump_check.py

    The node will actually dump state in the first epoch now with current
    epoch state sync
    marcelo-gonzalez committed Oct 26, 2024
    Configuration menu
    Copy the full SHA
    5133b31 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    0572ada View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    286693b View commit details
    Browse the repository at this point in the history