chore: De-duplicate code to create BlockHeader for genesis and view #12109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #12109 +/- ##
==========================================
+ Coverage 71.53% 71.59% +0.06%
==========================================
Files 818 818
Lines 164494 164367 -127
Branches 164494 164367 -127
==========================================
+ Hits 117667 117679 +12
+ Misses 41688 41549 -139
Partials 5139 5139
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Longarithm
approved these changes
Sep 19, 2024
Comment on lines
+989
to
+993
| assert_ne!( | ||
| signer.is_some(), | ||
| signature.is_some(), | ||
| "Exactly one of signer and signature must be provided" | ||
| ); |
There was a problem hiding this comment.
We should replace them with a single enum then, with two variants, e.g.
enum SignatureSource<'a> {
Signer(&'a ValidatorSigner)
Signature(Signature)
}
which documents itself.
| } | ||
|
|
||
| /// Common logic for generating BlockHeader for different purposes, including new blocks, from views, and for genesis block | ||
| fn new_impl( |
There was a problem hiding this comment.
We could probably unite arguments in BlockHeaderInnerLite, BlockHeaderInnerRestV1 (?) and the rest earlier to reduce number of arguments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We address a TODO item to use
BlockHeader::newwhen creating aBlockHeaderin two other places (today these places use similar logic to choose the rightBlockHeaderversion and contruct the inner structs based on the protocol version).BlockHeaderfromBlockHeaderView.BlockHeaderfor the genesis block.For this, we add
BlockHeader::new_implto contain the common code and have two other wrapper functions to callnew_implfor the use cases above:BlockHeader::from_viewandBlockHeader::genesis.