Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cleanup] Remove flat storage inline migration handler #12122

Merged
merged 2 commits into from
Sep 23, 2024

Conversation

shreyan-gupta
Copy link
Contributor

No longer needed after the migration.

I noticed while working on some refactoring wrt store.

Copy link

codecov bot commented Sep 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.46%. Comparing base (4fe8380) to head (963b4fb).
Report is 10 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #12122      +/-   ##
==========================================
- Coverage   71.52%   71.46%   -0.06%     
==========================================
  Files         819      818       -1     
  Lines      164694   164501     -193     
  Branches   164694   164501     -193     
==========================================
- Hits       117793   117568     -225     
- Misses      41762    41797      +35     
+ Partials     5139     5136       -3     
Flag Coverage Δ
backward-compatibility 0.17% <ø> (+<0.01%) ⬆️
db-migration 0.17% <ø> (+<0.01%) ⬆️
genesis-check 1.26% <ø> (+<0.01%) ⬆️
integration-tests 38.63% <ø> (-0.01%) ⬇️
linux 71.26% <ø> (-0.06%) ⬇️
linux-nightly 71.03% <ø> (-0.08%) ⬇️
macos 54.01% <ø> (+1.05%) ⬆️
pytests 1.52% <ø> (+<0.01%) ⬆️
sanity-checks 1.33% <ø> (+<0.01%) ⬆️
unittests 65.17% <ø> (-0.08%) ⬇️
upgradability 0.21% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shreyan-gupta shreyan-gupta added this pull request to the merge queue Sep 23, 2024
Merged via the queue into master with commit 59814e3 Sep 23, 2024
27 of 29 checks passed
@shreyan-gupta shreyan-gupta deleted the shreyan/cleanup/flat_inline_migration branch September 23, 2024 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants