Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(jsonrpc): Make trait RpcRequest a public and reimport near_jsonrpc_primitives as primitives #12169

Merged
merged 1 commit into from
Sep 30, 2024

Conversation

kobayurii
Copy link
Member

@kobayurii kobayurii commented Sep 30, 2024

This PR makes the RpcRequest trait public to allow for broader usage in external crates. Additionally, it re-imports near_jsonrpc_primitives as primitives to simplify references and improve code readability. This change is aimed at improving modularity and maintainability in the codebase.

2. reimport near_jsonrpc_primitives as primitives
@kobayurii kobayurii requested a review from khorolets September 30, 2024 08:38
@kobayurii kobayurii self-assigned this Sep 30, 2024
@kobayurii kobayurii marked this pull request as ready for review September 30, 2024 08:41
@kobayurii kobayurii requested a review from a team as a code owner September 30, 2024 08:41
@kobayurii kobayurii changed the title (jsonrpc): Make trait RpcRequest a public and reimport near_jsonrpc_primitives as primitives (jsonrpc): Make trait RpcRequest a public and reimport near_jsonrpc_primitives as primitives Sep 30, 2024
@kobayurii
Copy link
Member Author

@race-of-sloths please, include my PR in the Race

@race-of-sloths
Copy link

race-of-sloths commented Sep 30, 2024

@kobayurii Thank you for your contribution! Your pull request is now a part of the Race of Sloths!
Weekly streak is on the road, smart strategy! Secure your streak with another PR!

Shows profile picture for the author of the PR

Current status: executed
Reviewer Score
@race-of-sloths 2

Your contribution is much appreciated with a final score of 2!
You have received 42 (20 base + 20 weekly bonus + 5% lifetime bonus) Sloth points for this contribution

Another weekly streak completed, well done @kobayurii! To keep your weekly streak and get another bonus make pull request next week! Looking forward to see you in race-of-sloths

What is the Race of Sloths

Race of Sloths is a friendly competition where you can participate in challenges and compete with other open-source contributors within your normal workflow

For contributors:

  • Tag @race-of-sloths inside your pull requests
  • Wait for the maintainer to review and score your pull request
  • Check out your position in the Leaderboard
  • Keep weekly and monthly streaks to reach higher positions
  • Boast your contributions with a dynamic picture of your Profile

For maintainers:

  • Score pull requests that participate in the Race of Sloths
  • Engage contributors with fair scoring and fast responses so they keep their streaks
  • Promote the Race to the point where the Race starts promoting you
  • Grow the community of your contributors

Feel free to check our website for additional details!

Bot commands
  • For contributors
    • Include a PR: @race-of-sloths include to enter the Race with your PR
  • For maintainers:
    • Invite contributor @race-of-sloths invite to invite the contributor to participate in a race or include it, if it's already a runner.
    • Assign points: @race-of-sloths score [1/2/3/5/8/13] to award points based on your assessment.
    • Reject this PR: @race-of-sloths exclude to send this PR back to the drawing board.
    • Exclude repo: @race-of-sloths pause to stop bot activity in this repo until @race-of-sloths unpause command is called

Copy link

codecov bot commented Sep 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.58%. Comparing base (c3668d1) to head (fe95364).
Report is 2 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #12169      +/-   ##
==========================================
- Coverage   71.58%   71.58%   -0.01%     
==========================================
  Files         824      824              
  Lines      165173   165173              
  Branches   165173   165173              
==========================================
- Hits       118244   118232      -12     
- Misses      41797    41811      +14     
+ Partials     5132     5130       -2     
Flag Coverage Δ
backward-compatibility 0.17% <ø> (ø)
db-migration 0.17% <ø> (ø)
genesis-check 1.26% <ø> (ø)
integration-tests 38.76% <ø> (+0.02%) ⬆️
linux 71.37% <ø> (+<0.01%) ⬆️
linux-nightly 71.16% <ø> (-0.01%) ⬇️
macos 53.44% <ø> (-0.63%) ⬇️
pytests 1.52% <ø> (ø)
sanity-checks 1.32% <ø> (ø)
unittests 65.29% <ø> (-0.01%) ⬇️
upgradability 0.21% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@khorolets khorolets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In future we'd like to have it in a different publishable crate rather than in near-jsonrpc lib. Just for now it is acceptable.

@kobayurii kobayurii added this pull request to the merge queue Sep 30, 2024
Merged via the queue into near:master with commit 68324b1 Sep 30, 2024
30 checks passed
@kobayurii kobayurii deleted the improvement/rpc-request branch September 30, 2024 09:55
@race-of-sloths
Copy link

🥁 Score it!

@khorolets, please score the PR with @race-of-sloths score [1/2/3/5/8/13]. The contributor deserves it.
If no scoring is provided within 24 hours, this PR will be scored as 2 🦥

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants