-
Notifications
You must be signed in to change notification settings - Fork 658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(jsonrpc): Make trait RpcRequest
a public and reimport near_jsonrpc_primitives
as primitives
#12169
Conversation
2. reimport near_jsonrpc_primitives as primitives
RpcRequest
a public and reimport near_jsonrpc_primitives
as primitivesRpcRequest
a public and reimport near_jsonrpc_primitives
as primitives
@race-of-sloths please, include my PR in the Race |
@kobayurii Thank you for your contribution! Your pull request is now a part of the Race of Sloths! Current status: executed
Your contribution is much appreciated with a final score of 2! Another weekly streak completed, well done @kobayurii! To keep your weekly streak and get another bonus make pull request next week! Looking forward to see you in race-of-sloths What is the Race of SlothsRace of Sloths is a friendly competition where you can participate in challenges and compete with other open-source contributors within your normal workflow For contributors:
For maintainers:
Feel free to check our website for additional details! Bot commands
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #12169 +/- ##
==========================================
- Coverage 71.58% 71.58% -0.01%
==========================================
Files 824 824
Lines 165173 165173
Branches 165173 165173
==========================================
- Hits 118244 118232 -12
- Misses 41797 41811 +14
+ Partials 5132 5130 -2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In future we'd like to have it in a different publishable crate rather than in near-jsonrpc
lib. Just for now it is acceptable.
🥁 Score it! @khorolets, please score the PR with |
This PR makes the
RpcRequest
trait public to allow for broader usage in external crates. Additionally, it re-importsnear_jsonrpc_primitives
asprimitives
to simplify references and improve code readability. This change is aimed at improving modularity and maintainability in the codebase.