Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(state-sync): drop old state parts at the end of epoch #12200

Merged
merged 2 commits into from
Oct 16, 2024

Conversation

VanBarbascu
Copy link
Contributor

The current gc logic cleans state part column along with the blocks. By default 5 epochs. State parts older than an epoch are not needed. This introduces a change to drop the state sync files at the end of the epoch.

@VanBarbascu VanBarbascu requested a review from saketh-are October 9, 2024 15:20
@VanBarbascu VanBarbascu requested a review from a team as a code owner October 9, 2024 15:20
@VanBarbascu VanBarbascu force-pushed the state-sync-gc branch 2 times, most recently from d497cf8 to 85e1963 Compare October 16, 2024 12:12
@VanBarbascu VanBarbascu added this pull request to the merge queue Oct 16, 2024
Copy link

codecov bot commented Oct 16, 2024

Codecov Report

Attention: Patch coverage is 63.63636% with 4 lines in your changes missing coverage. Please review.

Project coverage is 71.75%. Comparing base (778b173) to head (63ef382).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
chain/chain/src/chain.rs 63.63% 0 Missing and 4 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #12200      +/-   ##
==========================================
+ Coverage   71.72%   71.75%   +0.02%     
==========================================
  Files         834      833       -1     
  Lines      166616   166547      -69     
  Branches   166616   166547      -69     
==========================================
- Hits       119512   119501      -11     
+ Misses      41886    41825      -61     
- Partials     5218     5221       +3     
Flag Coverage Δ
backward-compatibility 0.17% <0.00%> (+<0.01%) ⬆️
db-migration 0.17% <0.00%> (+<0.01%) ⬆️
genesis-check 1.25% <0.00%> (+<0.01%) ⬆️
integration-tests 38.74% <63.63%> (+0.01%) ⬆️
linux 71.41% <63.63%> (+0.02%) ⬆️
linux-nightly 71.32% <63.63%> (+0.02%) ⬆️
macos 54.43% <63.63%> (+0.02%) ⬆️
pytests 1.57% <0.00%> (+<0.01%) ⬆️
sanity-checks 1.37% <0.00%> (+<0.01%) ⬆️
unittests 65.57% <63.63%> (+0.02%) ⬆️
upgradability 0.21% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Merged via the queue into near:master with commit a23e94a Oct 16, 2024
27 of 30 checks passed
@VanBarbascu VanBarbascu deleted the state-sync-gc branch October 16, 2024 13:20
o
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants