-
Notifications
You must be signed in to change notification settings - Fork 658
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Given a day of the voting date find the hour that maximizes the probability that the upgrade happens during working hours #12204
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #12204 +/- ##
==========================================
- Coverage 71.84% 71.59% -0.26%
==========================================
Files 827 836 +9
Lines 166716 167470 +754
Branches 166716 167470 +754
==========================================
+ Hits 119783 119899 +116
- Misses 41718 42339 +621
- Partials 5215 5232 +17
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Thanks for taking the time to work on this!
Usage:
python3 estimate_epoch_start_time.py --chain_id mainnet --voting_date_day "2024-10-23" --timezone cet
Example Output