test: Add nayduck test for kicking out offline validators #12215
Conversation
tayfunelmas
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #12215 +/- ##
==========================================
- Coverage 71.84% 71.83% -0.01%
==========================================
Files 827 827
Lines 166624 166624
Branches 166624 166624
==========================================
- Hits 119705 119701 -4
- Misses 41701 41709 +8
+ Partials 5218 5214 -4
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
| [["epoch_length", EPOCH_LENGTH], ["num_block_producer_seats", 8], | ||
| ["num_chunk_producer_seats", 8], ["num_chunk_validator_seats", 16], |
There was a problem hiding this comment.
Why not 4 and 8? I don't understand how we can get chunk validator-only nodes with number of BPs and CPs = 8 and 8 nodes.
There was a problem hiding this comment.
because the epoch length was short I was thinking some node is not selected as a block producer, so I was playing with the seats instead to get the right assignment. Increasing epoch length helped, so reduced the seats back to 4/4/8.
We add a simple integration test for checking that offline nodes are kicked out properly. We kill a block+chunk producer and a chunk-validator only node. Assert that these two nodes are kicked out due to no block and endorsement production and not included in the next validators.
This is part of the testing tasks for #11900.