Revert (no longer needed) fix in db_migration test #12216
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tayfunelmas
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #12216 +/- ##
==========================================
- Coverage 71.84% 71.84% -0.01%
==========================================
Files 827 827
Lines 166624 166624
Branches 166624 166624
==========================================
- Hits 119704 119703 -1
+ Misses 41707 41700 -7
- Partials 5213 5221 +8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
wacban
approved these changes
Oct 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address the TODO in #11902.
Revert the fix to the db_migration test in #11899 (auto-revert did not work, sending manual revert). The code change in release 2.1 was substituted by increasing the GC window in the test (since the old binary was before 2.1) and since the old binary is already 2.2.1, the change in the test is no longer needed. See the TODO in the deleted code block for more context.