Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ping): prepend "near_" to metric names #12219

Merged
merged 1 commit into from
Oct 17, 2024

Conversation

marcelo-gonzalez
Copy link
Contributor

The ping tool currently crashes when initializing these metrics because the names starting with "near_" is now enforced with a panic

The ping tool currently crashes when initializing these metrics
because the names starting with "near_" is now enforced with a panic
@marcelo-gonzalez marcelo-gonzalez requested a review from a team as a code owner October 14, 2024 14:02
Copy link

codecov bot commented Oct 14, 2024

Codecov Report

Attention: Patch coverage is 0% with 3 lines in your changes missing coverage. Please review.

Project coverage is 71.82%. Comparing base (4fbd40d) to head (9b2c91a).
Report is 20 commits behind head on master.

Files with missing lines Patch % Lines
tools/ping/src/metrics.rs 0.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master   #12219      +/-   ##
==========================================
- Coverage   71.84%   71.82%   -0.02%     
==========================================
  Files         827      827              
  Lines      166624   166624              
  Branches   166624   166624              
==========================================
- Hits       119704   119684      -20     
- Misses      41707    41723      +16     
- Partials     5213     5217       +4     
Flag Coverage Δ
backward-compatibility 0.17% <0.00%> (ø)
db-migration 0.17% <0.00%> (ø)
genesis-check 1.25% <0.00%> (ø)
integration-tests 38.78% <0.00%> (-0.01%) ⬇️
linux 71.53% <0.00%> (+<0.01%) ⬆️
linux-nightly 71.41% <0.00%> (-0.01%) ⬇️
macos 53.01% <0.00%> (-1.53%) ⬇️
pytests 1.57% <0.00%> (ø)
sanity-checks 1.37% <0.00%> (ø)
unittests 65.64% <0.00%> (-0.02%) ⬇️
upgradability 0.21% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marcelo-gonzalez marcelo-gonzalez added this pull request to the merge queue Oct 17, 2024
Merged via the queue into near:master with commit fef9ddf Oct 17, 2024
29 of 30 checks passed
@marcelo-gonzalez marcelo-gonzalez deleted the ping-fix branch October 17, 2024 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants