[EpochSync] Cache epoch sync proof in memory for multiple requests. #12225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #12225 +/- ##
=======================================
Coverage 71.84% 71.85%
=======================================
Files 827 827
Lines 166716 166725 +9
Branches 166716 166725 +9
=======================================
+ Hits 119783 119800 +17
+ Misses 41718 41708 -10
- Partials 5215 5217 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
pugachAG
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's a very simple cache. We only cache the most recent epoch sync proof, in compressed format. The key of the cache is the EpochId. So whenever the EpochId changes, we recompute it.
Why don't we just store this on disk instead? It's unnecessary, and introduces more state to keep. Deriving the proof is not very expensive anyway (maybe a couple of seconds).