Use current protocol version in MockEpochManager #12304
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
KeyValueRuntime
creates aMockEpochManager
which returns epoch infos with protocol versions set to 1.The fact that some tests run with protocol version 1, but still use structs from the current protocol version messes up some checks that I'm trying to add.
Let's use the current protocol version in the mock epoch info. Running things with protocol version 1 isn't very realisitic anyway.
I had to fix one test which tests the "maintenance windows" feature - the maintenance windows (heights where a specific validator is not a block or chunk producer) were different in protocol version 1, I think this is because the validator assignment algorithm has changed. I think it's better to test the latest assignment algorithm.
I checked the new validator assignments by adding manual prints in the
get_maintenance_windows
function.