Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use T1 for sending chunk endorsements #12632

Merged
merged 1 commit into from
Dec 16, 2024
Merged

Conversation

pugachAG
Copy link
Contributor

We missed that when refactoring chunk endorsement logic. The old ChunkEndorsement message was removed in #12131, but we forgot to add the new message introduced in #11091.
I've noticed that by looking at mainnet metrics where VersionedChunkEndorsement message is only sent via T2.

@pugachAG pugachAG requested a review from a team as a code owner December 16, 2024 21:44
Copy link

codecov bot commented Dec 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.45%. Comparing base (164dc48) to head (db42601).
Report is 1 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff             @@
##           master   #12632       +/-   ##
===========================================
+ Coverage    1.67%   70.45%   +68.78%     
===========================================
  Files         669      845      +176     
  Lines      119598   172287    +52689     
  Branches   119598   172287    +52689     
===========================================
+ Hits         2000   121390   +119390     
+ Misses     117495    45787    -71708     
- Partials      103     5110     +5007     
Flag Coverage Δ
backward-compatibility 0.16% <ø> (?)
db-migration 0.16% <ø> (ø)
genesis-check 1.36% <ø> (ø)
linux 69.34% <ø> (+67.66%) ⬆️
linux-nightly 70.06% <ø> (?)
pytests 1.67% <ø> (ø)
sanity-checks 1.48% <ø> (ø)
unittests 70.28% <ø> (?)
upgradability 0.20% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pugachAG pugachAG enabled auto-merge December 16, 2024 22:02
Copy link
Collaborator

@saketh-are saketh-are left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should remove the catch-all _ => self == tcp::Tier::T2 and explicitly define the tier logic for every message type. It would prevent such problems in the future.

@pugachAG pugachAG added this pull request to the merge queue Dec 16, 2024
Merged via the queue into master with commit a794080 Dec 16, 2024
27 checks passed
@pugachAG pugachAG deleted the chunk-endorsement-t1 branch December 16, 2024 23:37
@pugachAG
Copy link
Contributor Author

@saketh-are great idea! see #12634

github-merge-queue bot pushed a commit that referenced this pull request Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants