Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add Dex addon #38

Merged
merged 64 commits into from
Feb 1, 2023
Merged

feat: Add Dex addon #38

merged 64 commits into from
Feb 1, 2023

Conversation

mile-misan
Copy link
Contributor

@mile-misan mile-misan commented Jan 23, 2023 •
edited by julianxhokaxhiu
Loading

What does this PR do?

This PR enables Kubernetes authentication using Dex, GitHub and Kubelogin plugin.
As the whole authentication flow is done with local domains and self-signed certificates, significant changes are implemented in order to support this condition.

Solution is tested with cluster running WSL and confirming the solution on MacOS and Linux is still to be done.

Related issues

Closes #23

Checklist before merging

  • My code follows the style guidelines of this project.
  • I have performed a self-review of my own code.
  • I have checked the contributing document.
  • I have checked the existing Pull Requests to see whether someone else has raised a similar idea or question.
  • I have added tests that prove my fix is effective or that my feature works.
  • I have upgraded the changelog according to the nature of the feature that I am adding to this Pull Request.

@julianxhokaxhiu julianxhokaxhiu changed the title Feat/dex GitHub use case feat: Add Dex Addon Jan 24, 2023
@julianxhokaxhiu julianxhokaxhiu added documentation Improvements or additions to documentation enhancement New feature or request labels Jan 24, 2023
@julianxhokaxhiu julianxhokaxhiu added this to the 0.1.0 milestone Jan 24, 2023
@julianxhokaxhiu julianxhokaxhiu changed the title feat: Add Dex Addon feat: Add Dex addon Jan 24, 2023
@mile-misan mile-misan marked this pull request as ready for review January 25, 2023 14:54
julianxhokaxhiu
julianxhokaxhiu previously approved these changes Jan 25, 2023
View reviewed changes
Copy link
Member

@julianxhokaxhiu julianxhokaxhiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Fantastic contribution. Thank you!

@mile-misan
Copy link
Contributor Author

Flow works fine on Linux and WSL. For OS X there's an issue with authenticating described in issue #49

zimny
zimny previously approved these changes Jan 31, 2023
View reviewed changes
Copy link
Collaborator

@zimny zimny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mile-misan mile-misan merged commit 62966d4 into main Feb 1, 2023
@mile-misan mile-misan deleted the feat/dex-github-use-case branch February 1, 2023 09:10
@nearform-renovate-app nearform-renovate-app bot mentioned this pull request Feb 1, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julianxhokaxhiu julianxhokaxhiu julianxhokaxhiu approved these changes

@zimny zimny zimny left review comments

Assignees

@mile-misan mile-misan

Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Milestone
0.1.0
Development

Successfully merging this pull request may close these issues.

[DEX] - Provide use-case for DEX
3 participants
@mile-misan @zimny @julianxhokaxhiu