Correct moving overrides, use warning instead of error

nebari-dev · Feb 21, 2024 · 80a6a24 · 80a6a24
1 parent b295aa6
commit 80a6a24
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/binder/postBuild b/binder/postBuild
@@ -8,6 +8,7 @@
 
         python3 binder/postBuild
 """
+import os
 import subprocess
 import sys
 from pathlib import Path
@@ -42,8 +43,10 @@ _("jupyter", "server", "extension", "list")
 # initially list installed extensions to determine if there are any surprises
 _("jupyter", "labextension", "list")
 
-_("mkdir", "-p", "$NB_PYTHON_PREFIX/share/jupyter/lab/settings/")
-_("cp", "binder/overrides.json", "$NB_PYTHON_PREFIX/share/jupyter/lab/settings/")
+# copy overrides.json to right location
+NB_PYTHON_PREFIX = os.environ["NB_PYTHON_PREFIX"]
+_("mkdir", "-p", f"{NB_PYTHON_PREFIX}/share/jupyter/lab/settings/")
+_("cp", "binder/overrides.json", f"{NB_PYTHON_PREFIX}/share/jupyter/lab/settings/")
 
 print("JupyterLab with jupyterlab_nebari_mode is ready to run with:\n")
 print("\tjupyter lab\n")
diff --git a/src/index.ts b/src/index.ts
@@ -78,7 +78,7 @@ const commandsPlugin: JupyterFrontEndPlugin<void> = {
       serverSettings
     );
     if (!response.ok) {
-      console.error('Server proxy info not available');
+      console.warn('Server proxy info not available');
       return;
     }
     const data = (await response.json()) as IServersInfo;