Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove cds dashboards references #26

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

remove cds dashboards references #26

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -170,8 +170,6 @@ The available configuration variables are:
:computer: You can see an example of these variables and the configuration in [`test_jupyterhub_config.py`](test_jupyterhub_config.py).

Nebari internal options:
- `cdsdashboards_enabled`: This requires [cdsdashboards](https://github.com/ideonate/cdsdashboards) to be present in the JupyterHub environment (`default: False`)
- `cdsdashboards_restricted`: This requires [cdsdashboards](https://github.com/ideonate/cdsdashboards) to be present in the JupyterHub environment (`default: False`)
- `nebari_theme_extra_js_urls`

## Architecture 🏗
Expand Down
8 changes: 0 additions & 8 deletions nebari_jupyterhub_theme/templates/page.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,6 @@
{% block nav_bar_left_items %}

<!-- Default nav bar items -->
<li class="nav-item"><a class="nav-link" href="{{base_url}}home {% if cdsdashboards_restricted %}-cds{% endif %}">Home</a></li>
<li class="nav-item"><a class="nav-link" href="{{base_url}}token">Token</a></li>

<!-- Access to admin dashboard -->
Expand All @@ -28,9 +27,6 @@
<!-- Custom integrations-->
<li class="nav-item"><a class="nav-link" href="/auth/admin/{{ keycloak_realm_name or 'nebari' }}/console/">User Management</a></li>
<li class="nav-item"><a class="nav-link" href="/argo">Argo Workflows</a></li>
{% if cdsdashboards_enabled %}
<li class="nav-item"><a class="nav-link" href="{{ base_url }}dashboards">Dashboards</a></li>
{% endif %}
<li class="nav-item"><a class="nav-link" href="/conda-store">Environment Management</a></li>
<li class="nav-item"><a class="nav-link" href="/monitoring">Monitoring</a></li>

Expand Down Expand Up @@ -68,10 +64,6 @@
{% include 'style.css' %}
</style>

{% if cdsdashboards_enabled %}
<link rel="stylesheet" href="{{base_url}}dashboards-static/css/style.css" type="text/css" />
{% endif %}

{% set jsurls = nebari_theme_extra_js_urls | default([]) %}
{% for jsurl in jsurls %}
<script type="text/javascript" src="{{ jsurl }}" defer></script>
Expand Down
24 changes: 0 additions & 24 deletions nebari_jupyterhub_theme/templates/style.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -293,27 +293,3 @@ a:hover{
font-family: var(--base-font-family);
word-wrap: break-word;
}

/* cdsdashboards */
#help-floater{
color: var(--light-text-color);
background: var(--primary-color);
font-family: var(--base-font-family);
}

ul.dashboard-selectable-tabs li{
color: var(--text-color);
font-family: var(--base-font-family);
text-decoration: underline;
}

ul.dashboard-selectable-tabs li.active{
color: var(--text-color);
font-family:var(--base-font-family);
background-color: var(--accent-color) !important;
}

#login-main .login_error,
.error{
color: var(--danger-color-dark);
}
Comment on lines -298 to -319
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assumed this whole section corresponded to CDS Dashboards, but I'm not certain that's true. Perhaps @trallard can chime in.