Removing custom dask_gateway from qhub and idle_timeout for dask clusters to 30 min #1151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
So, just to be sure. We will not support custom dask-gateway images then? |
|
@viniciusdc correct. The only reason that we used a custom version was due to needing a tls option to be set. |
costrouc
changed the title
|
@costrouc when you have some time, could you check the conflicts here? We tested this already right? |
|
Yeah @viniciusdc I will rebase and re-run the tests. |
|
Ready for review |
viniciusdc
approved these changes
Mar 21, 2022
|
Thanks for testing this @viniciusdc. Yes this will not fix the auth issues with jupyterlab extensions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removed our custom dask-gateway image from the configuration.