Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug where vscode extensions are not installing #1360

Merged
merged 36 commits into from
Jul 6, 2022

Conversation

viniciusdc
Copy link
Contributor

Fixes | Closes | Resolves #1350

Changes introduced in this PR:

  • This PR switched back the installation for the code-server backend to how it was previously provided before we moved to the conda-forge code-server feedstock.
  • Due to an issue with the docker build for the new image, which seems to be node related, I needed to bump the installation for the dask-labextension to the latest version as well

Types of changes

What types of changes does your PR introduce?

Put an x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features to not work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

Requires testing

  • Yes
  • No

In case you checked yes, did you write tests?

  • Yes
  • No
  • [ ]

Further comments (optional)

This should count as a quick fix for the current extension installation issue of VScode, but we need to revisit this after the current sprint.

@viniciusdc viniciusdc added area: user experience 👩🏻‍💻 area: integration/Dask Issues related to Dask on QHub area: dependencies 📦 All things dependencies area: JupyterLab status: in progress 🏗 This task is currently being worked on labels Jul 5, 2022
@viniciusdc
Copy link
Contributor Author

The previous extension mechanism is preserved
image

Also, the extension addition mechanism is now working:
image

from the Terminal:

test-user@jupyter-test-2duser:~/.local/share/code-server$ ls
CachedExtensionVSIXs  CachedExtensions  Machine  User  coder-logs  coder.json  heartbeat  logs  machineid
test-user@jupyter-test-2duser:~/.local/share/code-server$ 

@viniciusdc
Copy link
Contributor Author

I just need to test the dask-labextension to make sure it dint break anything

@viniciusdc
Copy link
Contributor Author

Dask-labextension is now fixed:
image

@viniciusdc
Copy link
Contributor Author

It seems that fixing the extensions broke the terminal sync with the Jupyterlab terminal (we now get a blank terminal on vscode), trying to fix that.

@costrouc
Copy link
Member

costrouc commented Jul 6, 2022

It seems that fixing the extensions broke the terminal sync with the Jupyterlab terminal (we now get a blank terminal on vscode), trying to fix that.

These components don't seem related not sure why this would be happening.

@viniciusdc
Copy link
Contributor Author

viniciusdc commented Jul 6, 2022

It seems that fixing the extensions broke the terminal sync with the Jupyterlab terminal (we now get a blank terminal on vscode), trying to fix that.

These components don't seem related not sure why this would be happening.

seems to be a node thing, the terminal is in there but it's not rendered correctly -- I am trying to change the /bin path to point directly to the code-server + node installation (as we have on quansight-beta), I also updated the order of calling the code-server proxy to use the conda env (I think it was being installed in the pip env of the docker image and not the default)

this is the error, for ref.:

[2022-07-06 12:40:58.929] [window] [error] [object Event]: Error: [object Event]
    at Object.E [as ensureError] (https://gcpqhubstages.qhub.dev/user/test-user/vscode/stable-30d9c6cd9483b2cc586687151bcbcd635f373630/static/out/vs/loader.js:3:4182)
    at i._createLoadError (https://gcpqhubstages.qhub.dev/user/test-user/vscode/stable-30d9c6cd9483b2cc586687151bcbcd635f373630/static/out/vs/loader.js:5:8131)
    at i._onLoadError (https://gcpqhubstages.qhub.dev/user/test-user/vscode/stable-30d9c6cd9483b2cc586687151bcbcd635f373630/static/out/vs/loader.js:5:8250)
    at f (https://gcpqhubstages.qhub.dev/user/test-user/vscode/stable-30d9c6cd9483b2cc586687151bcbcd635f373630/static/out/vs/loader.js:5:10089)
    at Object.errorback (https://gcpqhubstages.qhub.dev/user/test-user/vscode/stable-30d9c6cd9483b2cc586687151bcbcd635f373630/static/out/vs/loader.js:5:10445)
    at e.triggerErrorback (https://gcpqhubstages.qhub.dev/user/test-user/vscode/stable-30d9c6cd9483b2cc586687151bcbcd635f373630/static/out/vs/loader.js:3:11144)
    at https://gcpqhubstages.qhub.dev/user/test-user/vscode/stable-30d9c6cd9483b2cc586687151bcbcd635f373630/static/out/vs/loader.js:3:10850
    at HTMLScriptElement.f (https://gcpqhubstages.qhub.dev/user/test-user/vscode/stable-30d9c6cd9483b2cc586687151bcbcd635f373630/static/out/vs/loader.js:3:11365)

Copy link
Member

@iameskild iameskild left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @viniciusdc :)

@viniciusdc
Copy link
Contributor Author

viniciusdc commented Jul 6, 2022

So the bug with installing a new extension to vscode is now fixed, though for some reason the inbuilt terminal from the code-server does not work anymore, seems to be a proxy/port-related issue. -- This will be addressed in a future issue

@viniciusdc viniciusdc requested a review from costrouc July 6, 2022 21:22
@viniciusdc viniciusdc merged commit 4467325 into main Jul 6, 2022
@iameskild iameskild deleted the 1350-bug-vs-code-extensions-are-not-installing branch August 18, 2022 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: dependencies 📦 All things dependencies area: integration/Dask Issues related to Dask on QHub area: JupyterLab area: user experience 👩🏻‍💻 status: in progress 🏗 This task is currently being worked on
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] VS Code extensions are not installing
3 participants