Initial playwright setup #1665

kcpevey · 2023-02-28T14:34:06Z

Reference Issues or PRs

First setup of #1653

What does this implement/fix?

Put a x in the boxes that apply

New feature (non-breaking change which adds a feature)

Testing

Did you test the pull request locally?
Did you add new tests?

Any other comments?

tests_e2e/playwright/basic.py

kcpevey · 2023-03-09T17:01:54Z

A big challenge that I don't have a great solution for is sometimes jlab opens with a popup already open (requesting a kernel for a notebook) and sometimes it doesn't. Since its a popup, the only thing we have access to are the popup dialog items. The only solution I can find is to wrap a try/except around getting a popup dialog item. If it doesn't exist, it will fail and that's the only way I have to know that the popup doesn't exist. Not great, but I tried many other options and nothing worked.

costrouc · 2023-03-14T15:43:32Z

@kcpevey I'd like to split this PR into smaller PRs after we merge this initial PR. We should limit the scope to replacing only the cypress tests as an MVP. If possible too I'd like to minimize the number of abstrations we create. Then we work on adding each smaller feature. This PR as is just isn't well scoped and hard to finish in a certain amount of time.

kcpevey · 2023-03-16T16:11:09Z

@costrouc I completely agree. That's why I was hoping to get this first one merged before adding more tests. This just shows what I was hoping would be one "easy" integration test. I will add more details in the README on my vision of how the rest of the integration test suite would be filled out. I don't intend on removing cypress until we get a bunch of other PRs in and we're sure this is stable.

kcpevey · 2023-03-20T18:29:10Z

@costrouc @iameskild

When should the playwright tests run? I was thinking after a merge to develop or main?
Where should they run? I'm guessing on a test deployment of the current branch? Where can I find that? and the URL for it?

tests_e2e/playwright/basic.py

costrouc · 2023-03-20T18:55:26Z

@kcpevey I'd like the playwright tests to run in https://github.com/nebari-dev/nebari/blob/main/.github/workflows/kubernetes_test.yaml#L165-L169 and remove https://github.com/nebari-dev/nebari/blob/main/.github/workflows/kubernetes_test.yaml#L138-L163.

kcpevey · 2023-03-20T18:57:50Z

@kcpevey I'd like the playwright tests to run in https://github.com/nebari-dev/nebari/blob/main/.github/workflows/kubernetes_test.yaml#L165-L169 and remove https://github.com/nebari-dev/nebari/blob/main/.github/workflows/kubernetes_test.yaml#L138-L163.

Thanks! I think we should keep cypress for now and run both test suites until we have full coverage of the cypress tests with the playwright tests. Would you agree?

.github/workflows/kubernetes_test.yaml

tests_e2e/playwright/README.md

tests_e2e/playwright/conftest.py

pmeier · 2023-05-11T09:22:20Z

tests_e2e/playwright/navigator.py

+    import os
+
+    import dotenv


Maybe just different opinions on the style here. We usually don't scope imports by usage inside a file, i.e. if an import is only used in one function, it still goes at the top of the file. The only reason I use lazy imports is if the package in question is an optional dependency that might not be available, but is not needed for most parts of the module. That is not the case here. os is from the standard library and dotenv is a dev requirement.

I would prefer to put them at the top, but I won't block over this. Feel free to resolve without fix if you disagree with me.

pmeier · 2023-05-11T09:26:06Z

tests_e2e/playwright/test_playwright.py

+
+def test_notebook(navigator):
+    test_app = RunNotebook(navigator=navigator)
+    test_app.nav.clone_repo(


So the general dev workflow would be

Create the notebook

Push it to a branch

Put the branch name into the repo cloning

Repeat 2. every time you make a change to the notebook

? That is quite inconvenient. Is there no better way to get this file into the cluster whether it is deployed locally or remotely?

In any case, we definitely need to document this workflow in the README.

tests_e2e/playwright/navigator.py

Co-authored-by: Philip Meier <[email protected]>

iameskild · 2023-06-12T16:16:36Z

It looks like this is nearly complete. @kcpevey @pmeier is there anything else that we need to do here (aside from passing CI and fixing the merge conflicts)?

pmeier · 2023-06-19T08:18:57Z

We need to at least resolve #1665 (comment) before merge. Some documentation is missing and possibly some workflow improvements for better DevX. There are a few more open comments, but nothing blocking.

kcpevey · 2023-07-11T12:59:11Z

I'm going to try to carve out some time to get this wrapped up this week.

aktech · 2023-07-18T22:28:21Z

@kcpevey @pmeier @iameskild @costrouc I have changed the git clone to write file on the nebari instance via bash using cat and EOF to remove the dependency of having tests in a branch on github. I think this pull request is in good shape to be merged. I wanted to wrap this up as I might need this for creating some testing setup. Let me know if anyone have any objections/reviews/comments.

kcpevey · 2023-07-19T13:01:14Z

@aktech Thank you for taking this over! As for the reliance on a branch, that was just to show tests passing and not intended to be merged. Thank you improving things and pushing things through!

pmeier

A few minor things inline that I'll fix in a second. Apart from them we also need to document that this needs a user to be present on the cluster and we can't do with root. @aktech will add this. Afterwards, LGTM.

tests_e2e/playwright/.env.tpl

tests_e2e/playwright/README.md

pmeier

Thanks @kcpevey for the bulk of the work and @aktech for the polish. Happy with the result now. LGTM if CI is green!

aktech

thanks @kcpevey awesome work 🎉 and thanks @pmeier for persistence with this

initial playwright setup

3601e04

kcpevey added area: CI/CD 👷🏽‍♀️ status: in progress 🏗 This task is currently being worked on area:developer-experience 👩🏻‍💻 labels Feb 28, 2023

[pre-commit.ci] Apply automatic pre-commit fixes

635d99b

kcpevey mentioned this pull request Mar 3, 2023

META - Add playwright tests to replace (& expand) Cypress #1653

Closed

costrouc reviewed Mar 3, 2023

View reviewed changes

tests_e2e/playwright/basic.py Outdated Show resolved Hide resolved

trallard assigned kcpevey Mar 6, 2023

kcpevey and others added 2 commits March 9, 2023 10:57

update run notebook test, working well now

304c288

[pre-commit.ci] Apply automatic pre-commit fixes

d4f30f7

kcpevey added 9 commits March 20, 2023 12:47

add notebook for testing, clean up CI

bd4e939

Merge branch 'develop' into add_playwright

78e7fc4

use the right dotenv

481e788

run playwright tests under separate workflow

a57f3c4

change run location

6d20c98

run headless

1f1e141

ensure headless

be6c794

pass cli argument to pytest as fixture

aae1d16

typo...

4f8dc3d

kcpevey commented Mar 20, 2023

View reviewed changes

tests_e2e/playwright/basic.py Outdated Show resolved Hide resolved

kcpevey added 4 commits March 21, 2023 08:24

restrict tests on PRs to exclude playwright tests

ed4e830

add a few file types to gitignore

6e5ee6d

move playwright to k8s gh action

f6de84d

gh action syntax strikes again!

a2faeee

pmeier reviewed May 11, 2023

View reviewed changes

tests_e2e/playwright/navigator.py Show resolved Hide resolved

kcpevey and others added 4 commits May 11, 2023 13:42

more reviewer comments

93c703b

Update tests_e2e/playwright/conftest.py

5245dc4

Co-authored-by: Philip Meier <[email protected]>

fixture cleanup

902b466

Merge branch 'develop' into add_playwright

74e99c0

kcpevey mentioned this pull request May 22, 2023

[BUG] - Infracost CI and DO tests failing #1817

Closed

aktech added 5 commits July 18, 2023 21:10

fix typo

9d5ce0b

Merge branch 'develop' into add_playwright

11d6cf3

write notebook on the nebari cluster instead of cloning

7af2be8

remove cloning docs

2558c4a

add docs to write_file, open terminal etc

efaff5b

aktech requested a review from pmeier July 18, 2023 22:32

aktech and others added 2 commits July 18, 2023 23:46

change notebook path relative to playwright

76ff6db

[pre-commit.ci] Apply automatic pre-commit fixes

a0954b5

pmeier reviewed Jul 20, 2023

View reviewed changes

tests_e2e/playwright/.env.tpl Outdated Show resolved Hide resolved

tests_e2e/playwright/README.md Show resolved Hide resolved

tests_e2e/playwright/README.md Outdated Show resolved Hide resolved

tests_e2e/playwright/README.md Show resolved Hide resolved

pmeier and others added 4 commits July 20, 2023 14:44

address comments

eb9a768

Merge branch 'develop' into add_playwright

e803e2a

add docs about creating a user

e4d2a5f

add support for --headed and --slowmo

ece5d19

pmeier approved these changes Jul 20, 2023

View reviewed changes

aktech approved these changes Jul 20, 2023

View reviewed changes

fix login env variables

79aaba0

aktech merged commit 9bcf67f into develop Jul 20, 2023
25 checks passed

aktech deleted the add_playwright branch July 20, 2023 14:11

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Initial playwright setup #1665

Initial playwright setup #1665

kcpevey commented Feb 28, 2023 •

edited

Loading

kcpevey commented Mar 9, 2023

costrouc commented Mar 14, 2023

kcpevey commented Mar 16, 2023

kcpevey commented Mar 20, 2023 •

edited

Loading

costrouc commented Mar 20, 2023 •

edited

Loading

kcpevey commented Mar 20, 2023

pmeier May 11, 2023

pmeier May 11, 2023 •

edited

Loading

iameskild commented Jun 12, 2023

pmeier commented Jun 19, 2023

kcpevey commented Jul 11, 2023

aktech commented Jul 18, 2023 •

edited

Loading

kcpevey commented Jul 19, 2023

pmeier left a comment

pmeier left a comment

aktech left a comment

Initial playwright setup #1665

Initial playwright setup #1665

Conversation

kcpevey commented Feb 28, 2023 • edited Loading

Reference Issues or PRs

What does this implement/fix?

Testing

Any other comments?

kcpevey commented Mar 9, 2023

costrouc commented Mar 14, 2023

kcpevey commented Mar 16, 2023

kcpevey commented Mar 20, 2023 • edited Loading

costrouc commented Mar 20, 2023 • edited Loading

kcpevey commented Mar 20, 2023

pmeier May 11, 2023

Choose a reason for hiding this comment

pmeier May 11, 2023 • edited Loading

Choose a reason for hiding this comment

iameskild commented Jun 12, 2023

pmeier commented Jun 19, 2023

kcpevey commented Jul 11, 2023

aktech commented Jul 18, 2023 • edited Loading

kcpevey commented Jul 19, 2023

pmeier left a comment

Choose a reason for hiding this comment

pmeier left a comment

Choose a reason for hiding this comment

aktech left a comment

Choose a reason for hiding this comment

kcpevey commented Feb 28, 2023 •

edited

Loading

kcpevey commented Mar 20, 2023 •

edited

Loading

costrouc commented Mar 20, 2023 •

edited

Loading

pmeier May 11, 2023 •

edited

Loading

aktech commented Jul 18, 2023 •

edited

Loading