Pathlib everywhere

[pmeier]

Reference Issues or PRs

Closes #1713.

What does this implement/fix?

We are Buzz Lightyear here and Woody is someone stuck on Python < 3.4. As the title implies, this replaces os.path with pathlib.Path everywhere in the nebari package except for the templates. LMK if we want pathlib there as well.

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds a feature)
• Breaking change (fix or feature that would cause existing features not to work as expected)
• Documentation Update
• Code style update (formatting, renaming)
• Refactoring (no functional changes, no API changes)
• Build related changes
• Other (please describe):

Testing

• Did you test the pull request locally?
• Did you add new tests?

Any other comments?

[pmeier]

There is one file missing that I need to refactor. After that it should only be getting the tests green. I'm not sure if I have time this week to address this. But it is still on my backlog.

[pmeier]

/bot run tests

[github-actions]

Contributor Tests Triggered by @pmeier

• via comment
• Build is running here

[pmeier]

This is the only refactor I've made. Since the configuration file and output path is used by multiple subcommands, I've defined them once at the top. This avoids duplication in the code and makes it easier to maintain.

[Adam-D-Lewis]

@pmeier Looks like the Kubernetes tests fail https://github.com/nebari-dev/nebari/actions/runs/4940974457/jobs/8833155254 and also some merge conflicts

[iameskild]

@pmeier it looks like we will need update this PR due to the recent changes to the API. Is this something you'll have time for?

[pmeier]

I'm OOO for the better part of the next two weeks. Will pick it up after. Feel free to change the labels on the PR to indicstr that if necessary.

[iameskild]

Hi @pmeier, I know we've gone back and forth on this PR but do you have time to wrap this up? It's also worth noting that many of the changes in here will likely be overridden by the work coming from the extension-mechanism. Perhaps it would be better to wait until that work is complete...

[pmeier]

Unless there is some blocker I failed to see, I promise I finish it before tomorrows community meeting.

[iameskild]

Beautiful :)