Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test GCP/AWS Deployment with Pytest #1871

Merged
merged 111 commits into from
Aug 3, 2023
Merged

Test GCP/AWS Deployment with Pytest #1871

merged 111 commits into from
Aug 3, 2023

Conversation

aktech
Copy link
Member

@aktech aktech commented Jul 24, 2023

Reference Issues or PRs

Effort for fixing: #1862

This is on top of: #1867 (That should be merged before this)
This creates a test matrix for cloud deployments (do and aws for now)

Successful runs: https://github.com/nebari-dev/nebari/actions/runs/5647583461

  • Test GPU
  • Preemptible, etc
  • Moved all tests inside tests directory.
  • Enable logging in pytest
  • Misc..

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

Any other comments?

@aktech aktech requested a review from a team July 24, 2023 17:47
@aktech aktech changed the base branch from develop to test-setup July 26, 2023 10:31
@aktech aktech force-pushed the test_aws branch 2 times, most recently from 253b6bd to 12d2241 Compare July 26, 2023 13:56
Base automatically changed from test-setup to develop August 3, 2023 16:20
@aktech aktech merged commit fe23d04 into develop Aug 3, 2023
25 checks passed
@aktech aktech deleted the test_aws branch August 3, 2023 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: testing ✅ Testing needs: review 👀 This PR is complete and ready for reviewing project: JATIC Work item needed for the JATIC project
Projects
Development

Successfully merging this pull request may close these issues.

3 participants