Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: Add AWS integration test workflow, clean up #1977

Merged
merged 50 commits into from
Sep 14, 2023
Merged

CI: Add AWS integration test workflow, clean up #1977

merged 50 commits into from
Sep 14, 2023

Conversation

iameskild
Copy link
Member

Reference Issues or PRs

Related to #1951

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

Any other comments?

iameskild and others added 25 commits August 22, 2023 20:16
@iameskild
Add region to init cmd, update tests_integrations
8fbde6f
@iameskild
Clean up
cc25b9a
@iameskild
Shuffle functions
cadc0d5
@iameskild
Ensure region is handled carefully, set default values
ba4791e
@iameskild
Clean up kubernetes_version
96b46b4
@iameskild
Clean up
a4d17e2
@iameskild
Make region eager
cc88f8a
@iameskild
Merge branch 'develop' into 20230822
272b9f6
@iameskild
Merge branch 'develop' into 20230822
649bb77
@iameskild
Remove on_cloud for --cloud instead
4418a5b
@iameskild
Make project required
2193664
@iameskild
Update tests_integration README
ed95606
@iameskild
Update cli_init tests to include region
8e54303
@iameskild
Merge branch 'develop' into 20230822
b9a1c5a
@iameskild
Add more robust clean up for integration tests
561dedf
@iameskild
Add azure-mgmt-resource as a dependency
bcd0717
@iameskild
Handle test failure gracefully
e26d371
@iameskild
Minor updates
38d9d0b
@iameskild
Merge branch 'develop' into 20230822
b75d1c6
@iameskild
Merge branch 'develop' into 20230822
0bb61a6
@iameskild
Merge develop
08f5e51
@iameskild
Add azure storge_account_postfix to initialize
b1ab4c1
@iameskild
Remove empty nb
7a60401
@iameskild
Update azure cli validate test
0f5692a
@iameskild
Add AWS integration test workflow, clean up
104373c
@iameskild iameskild changed the base branch from develop to 20230822 September 4, 2023 22:18
@iameskild iameskild added this to the Release 2023.9.1 milestone Sep 12, 2023
@pavithraes pavithraes added the project: JATIC Work item needed for the JATIC project label Sep 13, 2023
@iameskild iameskild self-assigned this Sep 13, 2023
@iameskild
Copy link
Member Author

I commented out the GPU test for now as it kept timing out. I will test it manually and work on adding it to integration tests in another PR.

aktech
aktech approved these changes Sep 14, 2023
View reviewed changes
Copy link
Member

@aktech aktech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, apart from the nitpick comment.

@iameskild iameskild merged commit 1a570d1 into develop Sep 14, 2023
27 checks passed
@iameskild iameskild deleted the it_aws branch September 14, 2023 21:30
This was referenced Sep 18, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aktech aktech aktech approved these changes

Assignees

@iameskild iameskild

Labels
area: CI/CD 👷🏽‍♀️ area: testing ✅ Testing project: JATIC Work item needed for the JATIC project provider: AWS
Projects
🪴 Nebari Project Management
Archived in project
Milestone
2023.10.1
Development

Successfully merging this pull request may close these issues.
3 participants
@iameskild @aktech @pavithraes