Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: add azure integration #2061

Merged
merged 29 commits into from
May 30, 2024
Merged

CI: add azure integration #2061

merged 29 commits into from
May 30, 2024

Conversation

fangchenli
Copy link
Member

@fangchenli fangchenli commented Oct 11, 2023

Reference Issues or PRs

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

Any other comments?

@iameskild
Copy link
Member

I think you're encountering the same issue I did when I last attempted to update Azure to use OIDC: #1694

@dcmcand
Copy link
Contributor

dcmcand commented Mar 13, 2024

@viniciusdc can you take a look at this and see if you can pick this up?

@Adam-D-Lewis Adam-D-Lewis marked this pull request as ready for review May 30, 2024 22:20
@Adam-D-Lewis
Copy link
Member

Looks like it's working now and should be ready for review @viniciusdc @marcelovilla

@Adam-D-Lewis
Copy link
Member

LGTM!

@Adam-D-Lewis Adam-D-Lewis merged commit 4b301a8 into develop May 30, 2024
3 checks passed
@Adam-D-Lewis Adam-D-Lewis deleted the azure-integration branch May 30, 2024 22:52
@aktech
Copy link
Member

aktech commented May 31, 2024

Is this intended to run on every pull request?

@Adam-D-Lewis
Copy link
Member

Is this intended to run on every pull request?

@aktech No, the intent is just to run weekly with the others. I can fix later today or feel free to fix if desired.

@Adam-D-Lewis
Copy link
Member

Fixed now - #2498 (comment)

@aktech
Copy link
Member

aktech commented May 31, 2024

Awesome, thanks! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

6 participants