-
Notifications
You must be signed in to change notification settings - Fork 91
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Explicit config #2294
Merged
Merged
Explicit config #2294
Changes from all commits
Commits
Show all changes
150 commits
Select commit
Hold shift + click to select a range
14125a3
upgrade pydantic
fangchenli 48f26ba
run bump-pydantic
fangchenli b57c75f
uncomment Werror
fangchenli 250be86
Merge branch 'develop' into pydantic-v2
fangchenli 7912e37
[pre-commit.ci] Apply automatic pre-commit fixes
pre-commit-ci[bot] 4eb1e08
Merge branch 'develop' into pydantic-v2
fangchenli 553d021
update dependency in pyproject
fangchenli 9febc8a
Merge branch 'develop' into pydantic-v2
fangchenli 8e33010
Merge remote-tracking branch 'upstream/develop' into pydantic-v2
fangchenli 99cb520
Merge remote-tracking branch 'origin/pydantic-v2' into pydantic-v2
fangchenli 8fb92ff
fix typo
fangchenli 0967d52
fix cpu_guarantee type
fangchenli 1692797
fix typo
fangchenli bd76c4d
Merge branch 'develop' into pydantic-v2
fangchenli 708d165
Merge remote-tracking branch 'upstream/develop' into pydantic-v2
fangchenli 2f99cac
Merge remote-tracking branch 'origin/pydantic-v2' into pydantic-v2
fangchenli 82ec511
fix more validation errors
fangchenli aba88ec
[pre-commit.ci] Apply automatic pre-commit fixes
pre-commit-ci[bot] 3e645b4
fix more validator errors
fangchenli ff0682e
Merge remote-tracking branch 'origin/pydantic-v2' into pydantic-v2
fangchenli eaab189
[pre-commit.ci] Apply automatic pre-commit fixes
pre-commit-ci[bot] fb90cc6
Merge remote-tracking branch 'upstream/develop' into pydantic-v2
fangchenli b085e49
resolve conflict
fangchenli e520dcc
resolve conflict
fangchenli 91fb5b4
resolve conflict
fangchenli 5d0fca4
[pre-commit.ci] Apply automatic pre-commit fixes
pre-commit-ci[bot] 2935c1f
fix monkeypatch
fangchenli 961a278
revert printout
fangchenli f725534
[pre-commit.ci] Apply automatic pre-commit fixes
pre-commit-ci[bot] c543bdd
fix validation error
fangchenli 6b98638
set none
fangchenli 2f3bbae
[pre-commit.ci] Apply automatic pre-commit fixes
pre-commit-ci[bot] ef8dfb4
revert change
fangchenli a9d8d71
Merge branch 'develop' into pydantic-v2
fangchenli e920e5b
rebase
fangchenli 19af132
fix cli error test
fangchenli 819abe9
[pre-commit.ci] Apply automatic pre-commit fixes
pre-commit-ci[bot] d0c07e8
Merge branch 'develop' into pydantic-v2
fangchenli f3c518e
Merge remote-tracking branch 'upstream/develop' into pydantic-v2
fangchenli bfba588
Merge remote-tracking branch 'origin/pydantic-v2' into pydantic-v2
fangchenli 70a5803
Merge branch 'develop' into pydantic-v2
fangchenli afaf06a
[pre-commit.ci] Apply automatic pre-commit fixes
pre-commit-ci[bot] f6c8468
Merge branch 'develop' into pydantic-v2
fangchenli eb5afa7
resolve conflict
fangchenli 292087a
resolve conflict
fangchenli ec2417c
[pre-commit.ci] Apply automatic pre-commit fixes
pre-commit-ci[bot] f4aeef2
Merge branch 'develop' into pydantic-v2
fangchenli 41699ea
[pre-commit.ci] Apply automatic pre-commit fixes
pre-commit-ci[bot] 27ca9ff
Merge branch 'develop' into pydantic-v2
fangchenli 70c8f6c
Merge branch 'develop' into pydantic-v2
fangchenli 7b695f0
[pre-commit.ci] Apply automatic pre-commit fixes
pre-commit-ci[bot] dbf5157
resolve conflict
fangchenli ac0b6ae
resolve conflict
fangchenli a770d2a
[pre-commit.ci] Apply automatic pre-commit fixes
pre-commit-ci[bot] 5e57a3a
change varible name
fangchenli 7481469
refactor model validation
fangchenli bc3f5f6
[pre-commit.ci] Apply automatic pre-commit fixes
pre-commit-ci[bot] 4ff3236
Merge branch 'develop' into pydantic-v2
fangchenli 22bef83
Merge branch 'develop' into pydantic-v2
fangchenli e41f3a7
resolve conflict, uddate pydantic
fangchenli 2d0ee62
[pre-commit.ci] Apply automatic pre-commit fixes
pre-commit-ci[bot] 7d42def
resolve conflict
fangchenli 2f6cb7f
update
fangchenli bd50f0b
[pre-commit.ci] Apply automatic pre-commit fixes
pre-commit-ci[bot] a30760a
revert comment
fangchenli ba53843
update
fangchenli 6532f6a
[pre-commit.ci] Apply automatic pre-commit fixes
pre-commit-ci[bot] 8949cfe
update
fangchenli 64d5943
[pre-commit.ci] Apply automatic pre-commit fixes
pre-commit-ci[bot] 6c166cd
fix name
fangchenli acc7ebd
revert change
fangchenli 4dfd46c
debug
fangchenli f3775d7
Merge remote-tracking branch 'upstream/develop' into pydantic-v2
fangchenli 842de7b
update
fangchenli e4b458c
[pre-commit.ci] Apply automatic pre-commit fixes
pre-commit-ci[bot] a443deb
Merge branch 'develop' into pydantic-v2
fangchenli 69ea483
resolve conflict
fangchenli bc79fd6
unskip test
fangchenli 2da0b89
[pre-commit.ci] Apply automatic pre-commit fixes
pre-commit-ci[bot] ed1329d
uncomment
fangchenli 9f648c0
Merge remote-tracking branch 'origin/pydantic-v2' into pydantic-v2
fangchenli 8236673
remove fixture typing
fangchenli ae7d918
[pre-commit.ci] Apply automatic pre-commit fixes
pre-commit-ci[bot] b141ff3
resolve confilct
fangchenli deada6e
Merge remote-tracking branch 'origin/pydantic-v2' into pydantic-v2
fangchenli b3b5268
avoid import typing
fangchenli 3831b51
use fixture for cli
fangchenli b77a59a
[pre-commit.ci] Apply automatic pre-commit fixes
pre-commit-ci[bot] f14529a
debug conda build
fangchenli 3e46486
Merge remote-tracking branch 'upstream/develop' into pydantic-v2
fangchenli 33fde03
fix typing import in init
fangchenli ec07870
Merge remote-tracking branch 'upstream/develop' into pydantic-v2
fangchenli 5c50185
refactor env variable check
fangchenli 47b86eb
[pre-commit.ci] Apply automatic pre-commit fixes
pre-commit-ci[bot] 5cef9ce
Merge branch 'develop' into pydantic-v2
fangchenli 7c5b5cc
Merge branch 'develop' into pydantic-v2
aktech d74d69d
render all config before writing
Adam-D-Lewis 44c9f71
update
Adam-D-Lewis 12f5288
[pre-commit.ci] Apply automatic pre-commit fixes
pre-commit-ci[bot] 88d8bc4
split certs into different pydantic models
Adam-D-Lewis bbdf6f2
[pre-commit.ci] Apply automatic pre-commit fixes
pre-commit-ci[bot] b2891d1
allow each InputSchema to exclude certain parts of itself from the co…
Adam-D-Lewis 0e4d7fd
allow each InputSchema to exclude certain parts of itself from the co…
Adam-D-Lewis 845becb
import future annotations
Adam-D-Lewis b01446e
[pre-commit.ci] Apply automatic pre-commit fixes
pre-commit-ci[bot] 0df2e64
switch typing annotation to fix tests
Adam-D-Lewis 33f4712
switch typing annotation to fix tests
Adam-D-Lewis 4a80f23
Merge branch 'develop' into explicit_config
viniciusdc 4d824be
fix tests
Adam-D-Lewis 6e330e5
[pre-commit.ci] Apply automatic pre-commit fixes
pre-commit-ci[bot] 88b46a8
Merge branch 'develop' into pydantic2
Adam-D-Lewis 924659d
merge develop
Adam-D-Lewis 75d8e70
small fixes
Adam-D-Lewis a8bab5c
Merge branch 'develop' into pydantic2
Adam-D-Lewis 35252ef
fix arg of classmethod
Adam-D-Lewis 436dab7
fix req'd vars
Adam-D-Lewis 283150f
fix availability zones
Adam-D-Lewis b2dbbd9
undo signature change
Adam-D-Lewis 082cc41
fix fn call
Adam-D-Lewis 3d6726f
remove unused var in fn signature
Adam-D-Lewis 7e5891f
update cpu_limit dtype
Adam-D-Lewis 32ee7ba
update cpu_limit dtype
Adam-D-Lewis e1030d8
revert test changes unrelated to pydantic v2
Adam-D-Lewis 850de95
update for pydantic2
Adam-D-Lewis 6b2b629
fix tests
Adam-D-Lewis 473a1ee
Merge branch 'develop' into pydantic2
Adam-D-Lewis 9d9fd49
replace .dict( with .model_dump(
Adam-D-Lewis c4b8c6e
Merge branch 'develop' into pydantic2
Adam-D-Lewis 89e73aa
Merge branch 'develop' into pydantic2
Adam-D-Lewis 680ce25
merge with pydantic2
Adam-D-Lewis c8feabc
reverse base class order
Adam-D-Lewis 52b4ea8
merge with develop
Adam-D-Lewis 2b38f46
make fields optional
Adam-D-Lewis a46cf1d
add default values
Adam-D-Lewis d4f301d
merge develop
Adam-D-Lewis 8881d7c
merge develop
Adam-D-Lewis b88aa1b
remove validate default
Adam-D-Lewis 992ae28
make verbose not the default
Adam-D-Lewis e904428
fix tests
Adam-D-Lewis 7c90e58
Merge branch 'develop' into explicit_config
Adam-D-Lewis f4508cb
convert verbose from bool to count
Adam-D-Lewis e771897
revert cert changes
Adam-D-Lewis ef6caad
revert exclude from config
Adam-D-Lewis 1ec6087
update default value on verbose cli arg
Adam-D-Lewis f39e3aa
readd a bit from exclude_from_config
Adam-D-Lewis aa7426f
add advanced users only warning
Adam-D-Lewis 1d60cda
Merge branch 'develop' into explicit_config
Adam-D-Lewis 31cf77b
change verbose to explicit
Adam-D-Lewis 28bc17f
test explicit config
Adam-D-Lewis aaa7682
fix comment
Adam-D-Lewis File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Adam-D-Lewis is there any reason to have
int
overbool
here? I know either of those will work but I'm wondering if there is any advantage.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Making it an int allows you to specify
--explicit --explicit
or-ee
to have levels of explicitness. We aren't using the levels yet, but may in the future.