Update allowed admin groups

[aktech]

Reference Issues or PRs

Fixes #2436

Due to a recent change, adding jupyterhub_admin role to a user doesn't makes it admin for JupyterHub, this PR fixes that.

What does this implement/fix?

Put a x in the boxes that apply

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds a feature)
• Breaking change (fix or feature that would cause existing features not to work as expected)
• Documentation Update
• Code style update (formatting, renaming)
• Refactoring (no functional changes, no API changes)
• Build related changes
• Other (please describe):

Testing

• Did you test the pull request locally?
• Did you add new tests?

Any other comments?

[viniciusdc]

This needs to be tested; based on the changes, I don't foresee any problems. but its good to double check

[aktech]

This needs to be tested; based on the changes, I don't foresee any problems. but its good to double check

We tested this on Quansight deployment and a client deployment. This is a fix for the consequence of: 6a83ada

This could be soon removed, when we have roles syncing and proper permissions model, which is WIP. This PR is just be bring back the old behaviour meanwhile.

[viniciusdc]

Hi @aktech wouldn't this create conda-store namespaces and EFS share files for those then when a users receives such group?

[viniciusdc]

@krassowski, if you have some time today, could you just double-check that those permissions are enough?

[viniciusdc]

As this is a release blocker I will go ahead an merge this PR, and any extra thoughts can be done in a separate PR after the first RC

[viniciusdc]

LGTM