Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old develop branch references after default branch renaming #2769

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

marcelovilla
Copy link
Member

@marcelovilla marcelovilla commented Oct 13, 2024

Reference Issues or PRs

Closes #2770

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

How to test this PR?

You can manually trigger any of the cloud deployment workflows (i.e., AWS, Azure and Google Cloud) and specify main as the Nebari branch in the first text box (not from the dropdown menu in the first item).

Any other comments?

@Adam-D-Lewis
Copy link
Member

They appear to be passing now. Is this PR still needed?

image

@viniciusdc
Copy link
Contributor

viniciusdc commented Oct 14, 2024

I think the PR contents are still needed for legacy code removal, but the naming needs to be changed as well as the issue affiliation

@marcelovilla marcelovilla changed the title Fix failing cloud deployment tests after default branch renaming Remove old develop branch references after default branch renaming Oct 14, 2024
@marcelovilla
Copy link
Member Author

@Adam-D-Lewis huh, I thought this was the issue but you're right, they are passing now and pointing to the correct branch. As @viniciusdc mentioned, this PR is still relevant in the sense that it gets rid of old references to develop. I updated the issue title and opened and linked a new issue.

@marcelovilla marcelovilla merged commit 38960ea into main Oct 14, 2024
26 checks passed
@marcelovilla marcelovilla deleted the fix-cloud-deployments-ci branch October 14, 2024 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done 💪🏾
Development

Successfully merging this pull request may close these issues.

[ENH] - Old develop branch references after default branch renaming
3 participants