Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix CICD issue with pre-commit action #2775

Merged
merged 3 commits into from
Oct 15, 2024
Merged

fix CICD issue with pre-commit action #2775

merged 3 commits into from
Oct 15, 2024

Conversation

Adam-D-Lewis
Copy link
Member

@Adam-D-Lewis Adam-D-Lewis commented Oct 15, 2024

Reference Issues or PRs

We are experiencing a similar issue to pre-commit/action#210. This fixes the issue.

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

How to test this PR?

Any other comments?

@@ -196,7 +196,7 @@ def checkout_image_step():
def setup_python_step():
return GHA_job_step(
name="Set up Python",
uses="actions/setup-python@v4",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

flyby update this to be consistent with the rest of the repo

@Adam-D-Lewis Adam-D-Lewis requested review from dcmcand, viniciusdc and marcelovilla and removed request for viniciusdc October 15, 2024 14:58
@Adam-D-Lewis Adam-D-Lewis merged commit ccb8b7e into main Oct 15, 2024
28 checks passed
@Adam-D-Lewis Adam-D-Lewis deleted the fix-pre-commit-gha branch October 15, 2024 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done 💪🏾
Development

Successfully merging this pull request may close these issues.

2 participants