Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add config option to enable the encryption of AWS EKS secrets #2788

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

joneszc
Copy link
Contributor

@joneszc joneszc commented Oct 22, 2024

Reference Issues or PRs

Fixes #2681
Fixes #2746
Modifies PR#2723 (Failing Tests / Pytest)
Modifies PR#2752 (Failing Tests / Pytest)

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

How to test this PR?

Any other comments?

Allows user to set EKS encryption of secrets by specifying a KMS key ARN in nebari-config.yaml

amazon_web_services:
  eks_kms_arn: 'arn:aws:kms:us-east-1:010101010:key/3xxxxxxx-xxxxx-xxxxx-xxxxx'
image

The KMS key must meet the following conditions:

  • Symmetric
  • Can encrypt and decrypt data
  • Created in the same AWS Region as the cluster
  • If the KMS key was created in a different account, the IAM principal must have access to the KMS key.

@viniciusdc
Copy link
Contributor

@joneszc, there are two PRs which seem to add the same thing, this one and #2752 -- I assume the first one was the original; can you close this one? (or move any relevant changes back to the other PR?)

@viniciusdc viniciusdc added the needs: follow-up 📫 Someone needs to get back to this issue or PR label Oct 24, 2024
@dcmcand
Copy link
Contributor

dcmcand commented Oct 24, 2024

@joneszc can we close #2752 and #2723 since we have this one?

@joneszc
Copy link
Contributor Author

joneszc commented Oct 24, 2024

@joneszc can we close #2752 and #2723 since we have this one?

@dcmcand @viniciusdc
Yes, those two PRs were built on forks of the old develop branch that is now main
Thanks for help determining that the branch was not the issue causing Pytest failures. #2752 and #2723 can be closed.

@joneszc joneszc changed the title UPDATED2: Add config option to enable the encryption of AWS EKS secrets Add config option to enable the encryption of AWS EKS secrets Oct 24, 2024
@joneszc
Copy link
Contributor Author

joneszc commented Oct 24, 2024

@viniciusdc
I've opened PR#537 to update the docs per your request

@joneszc joneszc self-assigned this Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs: follow-up 📫 Someone needs to get back to this issue or PR
Projects
Status: New 🚦
3 participants