Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Azure AAD/EntraID access settings #2887

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from
Draft

Conversation

viniciusdc
Copy link
Contributor

Reference Issues or PRs

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

How to test this PR?

Any other comments?

@viniciusdc viniciusdc added this to the 2024.12.2 release milestone Dec 18, 2024
@viniciusdc
Copy link
Contributor Author

I just need to rename the enabled field since its misleading, its intent is to enable the usage of RBAC roles from Azure instead of the default kuberntes behavior which is an authorization change, works different then the others enabled flags on nebari right now (this does not refer to the actual toggle of this property in the cluster)

@dcmcand
Copy link
Contributor

dcmcand commented Dec 20, 2024

@viniciusdc is this ready for review?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: New 🚦
Development

Successfully merging this pull request may close these issues.

2 participants