-
Notifications
You must be signed in to change notification settings - Fork 96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add workflow to run conda-store user journey tests #2895
base: main
Are you sure you want to change the base?
Conversation
8bb4c2a
to
814d7e8
Compare
depends on conda-incubator/conda-store#1040 |
814d7e8
to
b58c5c7
Compare
Since these tests depend on a live cluster, I suggest extending the already existing local integration tests with this extra check https://github.com/nebari-dev/nebari/blob/main/.github/workflows/test_local_integration.yaml -- since it uses CiRun under the hood you should not be affected by any flakiness of the GH runner in case of constrained resources. |
8d941b5
to
c108c2f
Compare
a4e3482
to
a1f3c4d
Compare
Also depends on conda-incubator/conda-store#1050 |
a1f3c4d
to
f599bbc
Compare
id: conda-store-token | ||
working-directory: ${{ steps.init.outputs.directory }} | ||
run: | | ||
kubectl get secret -n default tfstate-default-${{ steps.init.outputs.project }}-dev-07-kubernetes-services --template={{.data}} | cut -d ":" -f2 | cut -d "]" -f1 | base64 --decode | gzip -d --to-stdout > terraform_state |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not very happy about this one. The user journey tests need a token to auth against conda-store. I tried a few different approaches to finding a token or generating a token but this is the only way that seemed to consistently work and could be done in CI. Definitely open to suggestions on how to make this better.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have not looked into the whole pr yet, just looking at this comment, is the following any good?
def get_conda_store_session(): |
nebari/tests/common/conda_store_utils.py
Line 34 in 43e63fe
token = session.cookies.get("conda-store-auth") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmmm, I did try this approach (but with curl). I think I was maybe missing this credentialId
piece though. Will give that another try. Thanks for the tip!
f599bbc
to
7810a00
Compare
e18ebef
to
65896b1
Compare
65896b1
to
d5f3827
Compare
d5f3827
to
8f11a28
Compare
Reference Issues or PRs
fixes #2760
What does this implement/fix?
Put a
x
in the boxes that apply