Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workflow to run conda-store user journey tests #2895

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

soapy1
Copy link
Contributor

@soapy1 soapy1 commented Jan 6, 2025

Reference Issues or PRs

fixes #2760

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe): CI change

@soapy1 soapy1 force-pushed the conda-store-black-box-testing branch 11 times, most recently from 8bb4c2a to 814d7e8 Compare January 7, 2025 22:09
@soapy1
Copy link
Contributor Author

soapy1 commented Jan 8, 2025

depends on conda-incubator/conda-store#1040

@viniciusdc
Copy link
Contributor

Since these tests depend on a live cluster, I suggest extending the already existing local integration tests with this extra check https://github.com/nebari-dev/nebari/blob/main/.github/workflows/test_local_integration.yaml -- since it uses CiRun under the hood you should not be affected by any flakiness of the GH runner in case of constrained resources.

@soapy1 soapy1 force-pushed the conda-store-black-box-testing branch 15 times, most recently from 8d941b5 to c108c2f Compare January 16, 2025 21:52
@soapy1
Copy link
Contributor Author

soapy1 commented Jan 23, 2025

Also depends on conda-incubator/conda-store#1050

@soapy1 soapy1 force-pushed the conda-store-black-box-testing branch from a1f3c4d to f599bbc Compare January 23, 2025 18:05
@soapy1 soapy1 marked this pull request as ready for review January 23, 2025 18:05
id: conda-store-token
working-directory: ${{ steps.init.outputs.directory }}
run: |
kubectl get secret -n default tfstate-default-${{ steps.init.outputs.project }}-dev-07-kubernetes-services --template={{.data}} | cut -d ":" -f2 | cut -d "]" -f1 | base64 --decode | gzip -d --to-stdout > terraform_state
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not very happy about this one. The user journey tests need a token to auth against conda-store. I tried a few different approaches to finding a token or generating a token but this is the only way that seemed to consistently work and could be done in CI. Definitely open to suggestions on how to make this better.

Copy link
Member

@aktech aktech Jan 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have not looked into the whole pr yet, just looking at this comment, is the following any good?

def get_conda_store_session():

token = session.cookies.get("conda-store-auth")

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmmm, I did try this approach (but with curl). I think I was maybe missing this credentialId piece though. Will give that another try. Thanks for the tip!

@soapy1 soapy1 force-pushed the conda-store-black-box-testing branch from f599bbc to 7810a00 Compare January 23, 2025 18:44
@soapy1 soapy1 requested review from aktech and viniciusdc January 23, 2025 19:35
@soapy1 soapy1 force-pushed the conda-store-black-box-testing branch 6 times, most recently from e18ebef to 65896b1 Compare January 27, 2025 20:38
@soapy1 soapy1 force-pushed the conda-store-black-box-testing branch from 65896b1 to d5f3827 Compare January 27, 2025 21:06
@soapy1 soapy1 force-pushed the conda-store-black-box-testing branch from d5f3827 to 8f11a28 Compare January 28, 2025 04:18
@soapy1 soapy1 marked this pull request as draft January 28, 2025 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: New 🚦
Development

Successfully merging this pull request may close these issues.

[ENH] - add conda-store black-box testing to ci
3 participants