Add extension configuration to enable in memory processing on demand …

…instead of enabled always, it helps workaround certain jar format issues but can cause out of memory for big jars so cannot be enabled all the time
nebula-plugins · Aug 15, 2023 · e291c65 · e291c65
1 parent aaa1c28
commit e291c65
Show file tree

Hide file tree

Showing 3 changed files with 23 additions and 1 deletion.
diff --git a/src/main/kotlin/com/netflix/gradle/jakartaee/JakartaEeMigrationExtension.kt b/src/main/kotlin/com/netflix/gradle/jakartaee/JakartaEeMigrationExtension.kt
@@ -86,6 +86,7 @@ public open class JakartaEeMigrationExtension(
     private val configuredCapabilities = AtomicBoolean()
     private val registeredTransform = AtomicBoolean()
     private val excludeSpecificationsTransform = AtomicBoolean()
+    private val transformInMemory = AtomicBoolean()
     private val preventTransformOfProductionConfigurations = AtomicBoolean()
     private val included = mutableListOf<ArtifactCoordinate>()
     private val excluded = mutableListOf<ArtifactCoordinate>()
@@ -304,8 +305,16 @@ public open class JakartaEeMigrationExtension(
                         .attribute(ARTIFACT_TYPE_ATTRIBUTE, ArtifactTypeDefinition.JAR_TYPE)
                     parameters.setIncludedArtifacts(included)
                     parameters.setExcludedArtifacts(excluded)
+                    parameters.setTransformInMemory(transformInMemory)
                 }
             }
         }
     }
+
+    /**
+     * Enables inmemory zip processing for migration tool.
+     */
+    public fun transformInMemory() {
+        transformInMemory.set(true)
+    }
 }
diff --git a/src/main/kotlin/com/netflix/gradle/jakartaee/JakartaEeMigrationTransform.kt b/src/main/kotlin/com/netflix/gradle/jakartaee/JakartaEeMigrationTransform.kt
@@ -34,6 +34,7 @@ import org.slf4j.LoggerFactory
 import java.io.FileNotFoundException
 import java.io.UncheckedIOException
 import java.nio.file.Files
+import java.util.concurrent.atomic.AtomicBoolean
 import java.util.logging.Handler
 import java.util.logging.Level
 import java.util.logging.LogRecord
@@ -55,6 +56,10 @@ internal abstract class JakartaEeMigrationTransform : TransformAction<JakartaEeM
         @Input
         fun getIncludedArtifacts(): List<ArtifactCoordinate>
         fun setIncludedArtifacts(includedArtifact: List<ArtifactCoordinate>)
+
+        @Input
+        fun getTransformInMemory(): AtomicBoolean
+        fun setTransformInMemory(transformInMemory: AtomicBoolean)
     }
 
     companion object {
@@ -83,6 +88,10 @@ internal abstract class JakartaEeMigrationTransform : TransformAction<JakartaEeM
         parameters.getIncludedArtifacts().toPaths()
     }
 
+    private val transformInMemory by lazy {
+        parameters.getTransformInMemory().get()
+    }
+
     private fun List<ArtifactCoordinate>.toPaths() = flatMap {
         listOf(
             "/${it.group}/${it.name}/", // Ivy repository layout. Gradle module cache
@@ -116,7 +125,7 @@ internal abstract class JakartaEeMigrationTransform : TransformAction<JakartaEeM
         migration.setDestination(tempFilePath.toFile())
         migration.eeSpecProfile = EESpecProfiles.EE
         migration.setEnableDefaultExcludes(false)
-        migration.setZipInMemory(true)
+        migration.setZipInMemory(transformInMemory)
 
         migration.execute()
 

diff --git a/src/test/groovy/com/netflix/gradle/jakartaee/TransformSpec.groovy b/src/test/groovy/com/netflix/gradle/jakartaee/TransformSpec.groovy
@@ -42,6 +42,10 @@ dependencies {
 dependencies {   
     implementation 'org.projectlombok:lombok:1.18.28'
 }
+
+jakartaeeMigration {
+    transformInMemory()
+}
 """
 
         when: