Version 1.2.0 (#28)

* Set min ruby version to 2.4 2.3 is EOL and no longer maintained. * Move contributors to separate file * Set version to 1.2.0 * bundle update * Update CHANGELOG for 1.2.0 * Add usage of DB password for Semaphore CI
nedap · Apr 25, 2019 · 4b87d0f · 4b87d0f
1 parent 2acfe74
commit 4b87d0f
Show file tree

Hide file tree

Showing 7 changed files with 23 additions and 10 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,11 @@
+# 1.2.0
+
+  * Set minimum Ruby version from 2.3 to 2.4 (2.3 is EOL and no longer maintained)
+  * Fixed an issue where a UUID would be unpacked again while it's a perfectly
+    fine UUID already.
+    Thanks @sirwolfgang
+
+
 # 1.1.1
 
   * Fixes possible SQL injection for ActiveRecord columns typed with

diff --git a/CONTRIBUTORS.md b/CONTRIBUTORS.md
@@ -0,0 +1,9 @@
+# Thank you!
+
+A word of thanks to all those that have contributed to this project:
+
+* Emmanuel Joubaud - [@ejoubaud](https://github.com/ejoubaud)
+* Geoff Evason - [@geoffevason](https://github.com/geoffevason)
+* Mark Oude Veldhuis - [@markoudev](https://github.com/markoudev)
+* Stanisław Pitucha - [@viraptor](https://github.com/viraptor)
+* Zane Wolfgang Pickett - [@sirwolfgang](https://github.com/sirwolfgang)
diff --git a/Gemfile.lock b/Gemfile.lock
@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    mysql-binuuid-rails (1.1.1)
+    mysql-binuuid-rails (1.2.0)
       rails (>= 5)
 
 GEM
@@ -74,7 +74,7 @@ GEM
     minitest-spec-context (0.0.3)
     mysql2 (0.4.10)
     nio4r (2.3.1)
-    nokogiri (1.10.2)
+    nokogiri (1.10.3)
       mini_portile2 (~> 2.4.0)
     rack (2.0.7)
     rack-test (1.1.0)

diff --git a/README.md b/README.md
@@ -154,11 +154,7 @@ https://github.com/nedap/mysql-binuuid-rails
 
 ## Contributors
 
-Thank you:
-
-  * Emmanuel Joubaud ([@ejoubaud](https://github.com/ejoubaud))
-  * Geoff Evason ([@geoffevason](https://github.com/geoffevason))
-  * Stanisław Pitucha ([@viraptor](https://github.com/viraptor))
+See [CONTRIBUTORS.md](CONTRIBUTORS.md).
 
 
 # License

diff --git a/lib/mysql-binuuid/version.rb b/lib/mysql-binuuid/version.rb
@@ -1,3 +1,3 @@
 module MySQLBinUUID
-  VERSION = "1.1.1"
+  VERSION = "1.2.0"
 end
diff --git a/mysql-binuuid-rails.gemspec b/mysql-binuuid-rails.gemspec
@@ -19,7 +19,7 @@ Gem::Specification.new do |spec|
     f.match(%r{^(test|spec|features)/})
   end
 
-  spec.required_ruby_version = ">= 2.3"
+  spec.required_ruby_version = ">= 2.4"
 
   spec.add_runtime_dependency "rails", ENV["RAILS_VERSION"] || ">= 5"
 

diff --git a/test/integration/mysql_integration_test.rb b/test/integration/mysql_integration_test.rb
@@ -19,7 +19,7 @@ def connection
     { adapter:  'mysql2',
       host:     'localhost',
       username: 'root',
-      password: '',
+      password: ENV['DATABASE_MYSQL_PASSWORD'] || '',
       database: 'binuuid_rails_test' }
   end