-
-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework pairing and host requesting #360
Merged
nefarius
merged 39 commits into
nefarius:master
from
Kanuan:custom-pairing-there-n-back-again
May 17, 2024
Merged
Rework pairing and host requesting #360
nefarius
merged 39 commits into
nefarius:master
from
Kanuan:custom-pairing-there-n-back-again
May 17, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Kanuan
commented
May 10, 2024
•
edited
Loading
edited
- Pairing now has 3 main modes:
- Auto: to active host
- Custom: to user defined Mac address
- Disabled: never occurs
- Pairing can be triggered manually by enabling the new PairOnHotReload and hot-reloading configurations
- Pairing is set to NOT occur if the desired new host is equal to the current set one, but I've included this option to prevent an edge case in which dshidmini could spam the controller on every hot reload with pairing requests if the driver failed to get the current controller's host
- Resolves Make pairing process occur on hot-reload #315
- DsHidMini now only sets the device's host request by sending the appropriate request to the controller
- Before it assumed the controller had set the new host address if the pairing request was sent successfully
- If the controller fails to respond to the request of its host address then DsHidMini will fallback to all zeroes host address
- Host is requested after each pairing attempt regardless if the pairing has succeeded or not, so it's possible to trigger the host requesting by enabling the PairOnHotReload config which will auto-trigger hot-reloading
- Resolves Only update device context's host address by using its respective GetFeature request #357
- Add "get host address" request status property
- Removed legacy "DisableAutoPair" config
- Pairing is only attempted after configurations have been loaded
Fixed error checking issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.