Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework pairing and host requesting #360

Merged
merged 39 commits into from
May 17, 2024

Conversation

Kanuan
Copy link
Collaborator

@Kanuan Kanuan commented May 10, 2024

  • Pairing now has 3 main modes:
    • Auto: to active host
    • Custom: to user defined Mac address
    • Disabled: never occurs
  • Pairing can be triggered manually by enabling the new PairOnHotReload and hot-reloading configurations
    • Pairing is set to NOT occur if the desired new host is equal to the current set one, but I've included this option to prevent an edge case in which dshidmini could spam the controller on every hot reload with pairing requests if the driver failed to get the current controller's host
    • Resolves Make pairing process occur on hot-reload #315
  • DsHidMini now only sets the device's host request by sending the appropriate request to the controller
    • Before it assumed the controller had set the new host address if the pairing request was sent successfully
    • If the controller fails to respond to the request of its host address then DsHidMini will fallback to all zeroes host address
    • Host is requested after each pairing attempt regardless if the pairing has succeeded or not, so it's possible to trigger the host requesting by enabling the PairOnHotReload config which will auto-trigger hot-reloading
    • Resolves Only update device context's host address by using its respective GetFeature request #357
  • Add "get host address" request status property
  • Removed legacy "DisableAutoPair" config
  • Pairing is only attempted after configurations have been loaded

@nefarius nefarius added this to the Version 3 milestone May 10, 2024
@nefarius nefarius self-assigned this May 12, 2024
@nefarius nefarius added enhancement New feature or request USB USB-related (wired) labels May 12, 2024
@nefarius nefarius merged commit a80eadf into nefarius:master May 17, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request USB USB-related (wired)
Projects
None yet
2 participants