Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add basic data layer #6

Closed
wants to merge 3 commits into from
Closed

Add basic data layer #6

wants to merge 3 commits into from

Conversation

jwoo0122
Copy link
Member

@jwoo0122 jwoo0122 commented Feb 8, 2021

  • Add axios
  • Add nvmrc
  • Add api, store files

Copy link

@apple12347678 apple12347678 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

store, derived가 데이터 레이어, 나머지가 뷰 레이어로 이해한게 맞는지? 흐름 자체는 명료하게 이해됨.

@@ -1,7 +1,16 @@
{
"extends": "@tsconfig/svelte/tsconfig.json",
"compilerOptions": {
"importsNotUsedAsValues": "preserve"
"importsNotUsedAsValues": "preserve",
"baseUrl": ".",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

baseUrl src로 설정하고 paths를 없애는 옵션에 대해선 어떻게 생각하는지?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

조아용 수정해서 업데이트 합니다

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

작업해보는 중인데, baseUrl 을 src 로 바꾸고 path 를 없애면 @rollup/plugin-alias 가 동작을 이상하게 하는 것 같음. svelte 파일에 대해서는 플러그인이 resolve 를 잘 해주나 ts 파일은 찾을 수 없다는 식으로 경고가 나옴.

baseUrl src 로 바꾸면 디렉토리 구조 바꿀 때 수정할 필요 없어서 편하긴 한데 alias 쪽이랑 충돌하는 문제 때문에 config 코드 더러워지는 거 감안하면 그냥 적당히 이대로 둬도 나쁘지 않을 것 같음.

정확히 무슨 문제인지는 더 리서치 필요함. rollup, typescript 문서 읽는 중.

큰 문제 아니라면 일단은 이렇게 넘어가고 issue 관리하는 편이 좋을 듯.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

정말 쓰레기 같아요 :)

Copy link
Member Author

@jwoo0122 jwoo0122 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

웹훅 테스트

Copy link
Member Author

@jwoo0122 jwoo0122 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

웹훅 테스트 2

@jwoo0122 jwoo0122 closed this Feb 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants