Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add tests for visa token #328

Merged
merged 4 commits into from
Nov 28, 2024
Merged

add tests for visa token #328

merged 4 commits into from
Nov 28, 2024

Conversation

Parisa68
Copy link
Contributor

Describe the pull request:

  • Bug fix
  • Functional change
  • New feature
  • Unit/integration tests
  • Code cleanup
  • Build system change
  • Documentation change

Pull request long description:

Related issues:

Additional information:

@Parisa68 Parisa68 marked this pull request as draft November 26, 2024 13:48
@Parisa68 Parisa68 marked this pull request as ready for review November 27, 2024 12:54
kjellp
kjellp approved these changes Nov 27, 2024
View reviewed changes
Copy link
Contributor

@kjellp kjellp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!
Should have some negative tests as well with visaTokens, but could be added as a separate issue now and solved in later PR.

@Parisa68 Parisa68 merged commit fc96ac5 into master Nov 28, 2024
5 checks passed
@Parisa68 Parisa68 deleted the visa-token-tests branch November 28, 2024 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjellp kjellp kjellp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Parisa68 @kjellp