Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modify filepath not storing the user id part (to be continued) #1097

Open
kostas-kou opened this issue Oct 23, 2024 · 2 comments · May be fixed by #1161
Open

Modify filepath not storing the user id part (to be continued) #1097

kostas-kou opened this issue Oct 23, 2024 · 2 comments · May be fixed by #1161
Assignees

Comments

@kostas-kou
Copy link
Contributor

kostas-kou commented Oct 23, 2024

Note that changes to the first step makes all other things break, so this has to be kept on a separate branch until it can be merged into the master branch.

As a developer
I want to change the way the filepath is stored in database (remove the user id part)
so that the user is not part of the filepath

Note

Changes required in these places:

  • s3inbox should not store the userid as part of the filename in the database
    • the message to cega should not include the userid in the filepath (no message should include the userid in the filepath).
  • ingest needs to be able to find the file, so it has to concatenate the userid
  • mapper needs to be able to remove the file from the inbox
  • download - no change if it's fixed above
    • s3
    • encrypted s3
    • decrypted REST
@kostas-kou kostas-kou changed the title Modify filepath not storing the user id part Modify filepath not storing the user id part (to be continued) Oct 23, 2024
@nanjiangshu
Copy link
Contributor

API endpoints that reveals the user-ids as listed in the issue #1095 should be fixed

@MalinAhlberg MalinAhlberg self-assigned this Nov 25, 2024
@MalinAhlberg
Copy link
Contributor

The filepaths should not start with a /

@MalinAhlberg MalinAhlberg linked a pull request Dec 3, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants