Merge pull request #56 from neiman-marcus/update-serverless3-node20

Update serverless3 node20
neiman-marcus · Apr 11, 2024 · 8062992 · 8062992
2 parents b37d162 + 954d1cc
commit 8062992
Show file tree

Hide file tree

Showing 11 changed files with 4,814 additions and 5,739 deletions.
diff --git a/.eslintrc.json b/.eslintrc.json
@@ -15,8 +15,7 @@
     "plugin:@typescript-eslint/eslint-recommended",
     "plugin:@typescript-eslint/recommended",
     "plugin:jest/recommended",
-    "prettier",
-    "prettier/@typescript-eslint"
+    "prettier"
   ],
   "rules": {}
 }
diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml
@@ -17,7 +17,7 @@ jobs:
       - name: setup
         uses: actions/setup-node@v1
         with:
-          node-version: '12.x'
+          node-version: '20.x'
 
       - name: install
         run: npm ci

diff --git a/README.md b/README.md
@@ -22,6 +22,9 @@ $ npm install serverless-provisioned-concurrency-autoscaling
 
 Add the plugin to your `serverless.yml`:
 
+Use version 1.9.1 for Serverless 1/ Serverless 2
+Use version 2.0.0 for Serverless 3
+
 ```yaml
 plugins:
   - serverless-provisioned-concurrency-autoscaling
@@ -147,6 +150,7 @@ N/A
 
 - [Clay Danford](mailto:[email protected])
 - [Dawid Boissé](mailto:[email protected])
+- [Vinoth Kumar Chandrasekar]([email protected])
 
 ## Conduct / Contributing / License
 

diff --git a/__tests__/helpers/serverless.ts b/__tests__/helpers/serverless.ts
@@ -17,7 +17,7 @@ export const serverless: any = {
         package: {},
         memory: 1024,
         timeout: 6,
-        runtime: 'nodejs12.x',
+        runtime: 'nodejs20.x',
         vpc: {},
         versionLogicalId:
           'HelloLambdaVersion0Otd4P0e98XajR4keLBshIyWK1yyxFOZK9AJZD7Wo',

diff --git a/__tests__/helpers/target.ts b/__tests__/helpers/target.ts
@@ -11,7 +11,7 @@ export const expectedTarget = {
       ServiceNamespace: 'lambda',
       RoleARN: {
         'Fn::Sub':
-          'arn:aws:iam::${AWS::AccountId}:role/aws-service-role/lambda.application-autoscaling.amazonaws.com/AWSServiceRoleForApplicationAutoScaling_LambdaConcurrency',
+          'arn:aws:iam::#{AWS::AccountId}:role/aws-service-role/lambda.application-autoscaling.amazonaws.com/AWSServiceRoleForApplicationAutoScaling_LambdaConcurrency',
       },
     },
     Type: 'AWS::ApplicationAutoScaling::ScalableTarget',
@@ -29,7 +29,7 @@ export const expectedTargetWithSingleScheduledAction = {
       ServiceNamespace: 'lambda',
       RoleARN: {
         'Fn::Sub':
-          'arn:aws:iam::${AWS::AccountId}:role/aws-service-role/lambda.application-autoscaling.amazonaws.com/AWSServiceRoleForApplicationAutoScaling_LambdaConcurrency',
+          'arn:aws:iam::#{AWS::AccountId}:role/aws-service-role/lambda.application-autoscaling.amazonaws.com/AWSServiceRoleForApplicationAutoScaling_LambdaConcurrency',
       },
       ScheduledActions: [
         {
@@ -56,7 +56,7 @@ export const expectedTargetWithScheduledActions = {
       ServiceNamespace: 'lambda',
       RoleARN: {
         'Fn::Sub':
-          'arn:aws:iam::${AWS::AccountId}:role/aws-service-role/lambda.application-autoscaling.amazonaws.com/AWSServiceRoleForApplicationAutoScaling_LambdaConcurrency',
+          'arn:aws:iam::#{AWS::AccountId}:role/aws-service-role/lambda.application-autoscaling.amazonaws.com/AWSServiceRoleForApplicationAutoScaling_LambdaConcurrency',
       },
       ScheduledActions: [
         {