Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recaptcha disable flag + null order fix #9505

Merged
merged 2 commits into from
Sep 16, 2024

Don't break if there's a null order in the system

edf3d88
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

Recaptcha disable flag + null order fix #9505

Don't break if there's a null order in the system
edf3d88
Select commit
Loading
Failed to load commit list.
GitHub Actions / rubocop failed Sep 16, 2024 in 0s

reviewdog [rubocop] report

reported by reviewdog 🐶

Findings (2)

app/controllers/registrations_controller.rb|26 col 35| Move locale texts to the locale files in the config/locales directory.
app/presenters/convention_reports_presenter.rb|23 col 14| Use where.not(product_id: nil) instead of manually constructing negated SQL in where.

Filtered Findings (0)

Annotations

Check notice on line 26 in app/controllers/registrations_controller.rb

See this annotation in the file changed.

@github-actions github-actions / rubocop

[rubocop] app/controllers/registrations_controller.rb#L26 <Rails/I18nLocaleTexts> 

Move locale texts to the locale files in the `config/locales` directory.
Raw output 
app/controllers/registrations_controller.rb:26:35: C: Rails/I18nLocaleTexts: Move locale texts to the locale files in the `config/locales` directory.

Check notice on line 23 in app/presenters/convention_reports_presenter.rb

See this annotation in the file changed.

@github-actions github-actions / rubocop

[rubocop] app/presenters/convention_reports_presenter.rb#L23 <Rails/WhereNot> 

Use `where.not(product_id: nil)` instead of manually constructing negated SQL in `where`.
Raw output 
app/presenters/convention_reports_presenter.rb:23:14: C: Rails/WhereNot: Use `where.not(product_id: nil)` instead of manually constructing negated SQL in `where`.
View more details on GitHub Actions