fix: IsHost is defined as false on windows

[ChristopherHX]

Sorry the last change didn't work.

However it would be useful to not comment it works if you didn't tested it.

Maybe fixes #2074

IsHost is even defined to false on windows, the host default of act makes the docker cli/api package buggy.

[github-actions]

🦙 MegaLinter status: ✅ SUCCESS

Descriptor	Linter	Files	Fixed	Errors	Elapsed time
✅ EDITORCONFIG	editorconfig-checker	1		0	0.01s
✅ REPOSITORY	gitleaks	yes		no	2.36s
✅ REPOSITORY	git_diff	yes		no	0.17s
✅ REPOSITORY	grype	yes		no	9.16s
✅ REPOSITORY	secretlint	yes		no	1.08s
✅ REPOSITORY	trivy-sbom	yes		no	0.63s
✅ REPOSITORY	trufflehog	yes		no	15.95s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by

[codecov]

Codecov Report

Attention: 872 lines in your changes are missing coverage. Please review.

Comparison is base (4989f44) 61.22% compared to head (274a246) 61.60%.
Report is 284 commits behind head on master.

Files	Patch %	Lines
pkg/artifactcache/handler.go	65.46%	102 Missing and 42 partials ⚠️
pkg/runner/run_context.go	73.37%	75 Missing and 19 partials ⚠️
pkg/runner/expression.go	55.17%	66 Missing and 12 partials ⚠️
pkg/runner/action_cache.go	50.74%	49 Missing and 17 partials ⚠️
pkg/container/docker_network.go	0.00%	56 Missing ⚠️
pkg/container/docker_run.go	2.00%	48 Missing and 1 partial ⚠️
pkg/model/workflow.go	43.37%	40 Missing and 7 partials ⚠️
pkg/common/outbound_ip.go	0.00%	44 Missing ⚠️
pkg/container/host_environment.go	0.00%	43 Missing ⚠️
pkg/artifactcache/storage.go	60.22%	24 Missing and 11 partials ⚠️
... and 25 more

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #2093      +/-   ##
==========================================
+ Coverage   61.22%   61.60%   +0.38%     
==========================================
  Files          46       53       +7     
  Lines        7141     8806    +1665     
==========================================
+ Hits         4372     5425    +1053     
- Misses       2462     2950     +488     
- Partials      307      431     +124     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[ChristopherHX]

Missing Windows CI for linux Containers, change might only work on linux.

I strongly recommend to test this on a windows machine before approving it.

[RedBrumbler]

I ran into the networking issue from #2074 and this PR fixes that, thanks

Act version that's broken: release 0.2.54 from choco
The artifact from this PR ran the actions for me.

[tadghh]

Any update on this? Windows users are stuck on version 0.2.51 otherwise

[ChristopherHX]

Any update on this? Windows users are stuck on version 0.2.51 otherwise

No, I don't have permission to continue