Skip to content

Commit

Permalink
feat: add tracking logs
Browse files Browse the repository at this point in the history
  • Loading branch information
andrey-canon committed Dec 4, 2023
1 parent e5b05da commit 329502f
Show file tree
Hide file tree
Showing 4 changed files with 109 additions and 0 deletions.
38 changes: 38 additions & 0 deletions completion_aggregator/models.py
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@

from __future__ import absolute_import, division, print_function, unicode_literals

from eventtracking import tracker
from opaque_keys.edx.django.models import CourseKeyField, UsageKeyField
from opaque_keys.edx.keys import CourseKey, UsageKey

Expand Down Expand Up @@ -171,8 +172,44 @@ def submit_completion(self, user, course_key, block_key, aggregation_name, earne
'last_modified': last_modified,
},
)
self.emit_completion_aggregator_logs([obj])

return obj, is_new

@staticmethod
def emit_completion_aggregator_logs(updated_aggregators):
"""
Emit a tracking log for each element of the list parameter.
Parameters
----------
updated_aggregators: List of Aggregator intances
"""
for obj in updated_aggregators:
event = "progress" if obj.percent < 1 else "completion"
event_type = obj.aggregation_name

if event_type not in settings.ALLOWED_COMPLETION_AGGREGATOR_EVENT_TYPES.get(event, []):
continue

event_name = f"edx.completion_aggregator.{event}.{event_type}"

tracker.emit(
event_name,
{
"user_id": obj.user_id,
"course_id": str(obj.course_key),
"block_id": str(obj.block_key),
"modified": obj.modified,
"created": obj.created,
"earned": obj.earned,
"possible": obj.possible,
"percent": obj.percent,
"type": event_type,
}
)

def bulk_create_or_update(self, updated_aggregators):
"""
Update the collection of aggregator object using mysql insert on duplicate update query.
Expand All @@ -194,6 +231,7 @@ def bulk_create_or_update(self, updated_aggregators):
else:
aggregation_data = [obj.get_values() for obj in updated_aggregators]
cur.executemany(INSERT_OR_UPDATE_AGGREGATOR_QUERY, aggregation_data)
self.emit_completion_aggregator_logs(updated_aggregators)


class Aggregator(TimeStampedModel):
Expand Down
17 changes: 17 additions & 0 deletions completion_aggregator/settings/common.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,23 @@ def plugin_settings(settings):
"""
Modify the provided settings object with settings specific to this plugin.
"""
# Emit feature allows to publish two kind of events progress and completion
# This setting controls which type of event will be published to change the default behavior
# the block type should be removed or added from the progress or completion list.
settings.ALLOWED_COMPLETION_AGGREGATOR_EVENT_TYPES = {
"progress": [
"course",
"chapter",
"sequential",
"vertical",
],
"completion": [
"course",
"chapter",
"sequential",
"vertical",
]
}
settings.COMPLETION_AGGREGATOR_BLOCK_TYPES = {
'course',
'chapter',
Expand Down
17 changes: 17 additions & 0 deletions test_settings.py
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,20 @@ def root(*args):
return join(abspath(dirname(__file__)), *args)


ALLOWED_COMPLETION_AGGREGATOR_EVENT_TYPES = {
"progress": [
"course",
"chapter",
"sequential",
"vertical",
],
"completion": [
"course",
"chapter",
"sequential",
"vertical",
]
}
AUTH_USER_MODEL = 'auth.User'
CELERY_ALWAYS_EAGER = True
COMPLETION_AGGREGATOR_BLOCK_TYPES = {'course', 'chapter', 'sequential'}
Expand Down Expand Up @@ -53,6 +67,7 @@ def root(*args):
'oauth2_provider',
'waffle',
'test_utils.test_app',
'eventtracking.django.apps.EventTrackingConfig',
)

LOCALE_PATHS = [root('completion_aggregator', 'conf', 'locale')]
Expand Down Expand Up @@ -81,5 +96,7 @@ def root(*args):
]
USE_TZ = True

EVENT_TRACKING_ENABLED = True

# pylint: disable=unused-import,wrong-import-position
from test_utils.test_app import celery # isort:skip
37 changes: 37 additions & 0 deletions tests/test_models.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,10 @@
import ddt
import pytest
import six
from mock import patch
from opaque_keys.edx.keys import UsageKey

from django.conf import settings
from django.contrib.auth import get_user_model
from django.core.exceptions import ValidationError
from django.test import TestCase
Expand All @@ -31,6 +33,12 @@ class AggregatorTestCase(TestCase):
def setUp(self):
super().setUp()
self.user = get_user_model().objects.create(username='testuser')
self.tracker_patch = patch('completion_aggregator.models.tracker')
self.tracker_mock = self.tracker_patch.start()

def tearDown(self):
"""Stop patching."""
self.tracker_mock.stop()

def test_submit_completion_with_invalid_user(self):
with pytest.raises(TypeError):
Expand All @@ -43,6 +51,7 @@ def test_submit_completion_with_invalid_user(self):
possible=27.0,
last_modified=now(),
)
self.tracker_mock.assert_not_called()

@ddt.data(
# Valid arguments
Expand All @@ -64,6 +73,7 @@ def test_submit_completion_with_valid_data(self, block_key_obj, aggregate_name,
self.assertEqual(obj.earned, earned)
self.assertEqual(obj.possible, possible)
self.assertEqual(obj.percent, expected_percent)
self.assert_emit_method_called(obj)

@ddt.data(
# Earned greater than possible
Expand Down Expand Up @@ -105,6 +115,7 @@ def test_submit_completion_with_exception(
)

self.assertEqual(exception_message, str(context_manager.exception))
self.tracker_mock.assert_not_called()

@ddt.data(
(
Expand All @@ -129,6 +140,7 @@ def test_aggregate_completion_string(
f'{six.text_type(block_key_obj)}: {expected_percent}'
)
self.assertEqual(six.text_type(obj), expected_string)
self.assert_emit_method_called(obj)

@ddt.data(
# Changes the value of earned. This does not create a new object.
Expand Down Expand Up @@ -179,6 +191,7 @@ def test_submit_completion_twice_with_changes(
)
self.assertEqual(obj.percent, expected_percent)
self.assertTrue(is_new)
self.assert_emit_method_called(obj)

new_obj, is_new = Aggregator.objects.submit_completion(
user=self.user,
Expand All @@ -193,6 +206,7 @@ def test_submit_completion_twice_with_changes(
self.assertEqual(is_new, is_second_obj_new)
if is_second_obj_new:
self.assertNotEqual(obj.id, new_obj.id)
self.assert_emit_method_called(new_obj)

@ddt.data(
(BLOCK_KEY_OBJ, 'course', 0.5, 1, 0.5),
Expand All @@ -211,3 +225,26 @@ def test_get_values(self, block_key_obj, aggregate_name, earned, possible, expec
values = aggregator.get_values()
self.assertEqual(values['user'], self.user.id)
self.assertEqual(values['percent'], expected_percent)

def assert_emit_method_called(self, obj):
"""Verify that the tracker.emit method was called once with the right values."""
if obj.aggregation_name not in settings.ALLOWED_COMPLETION_AGGREGATOR_EVENT_TYPES:
return

event = "progress" if obj.percent < 1 else "completion"

self.tracker_mock.emit.assert_called_once_with(
f"edx.completion_aggregator.{event}.{obj.aggregation_name}",
{
"user_id": obj.user_id,
"course_id": str(obj.course_key),
"block_id": str(obj.block_key),
"modified": obj.modified,
"created": obj.created,
"earned": obj.earned,
"possible": obj.possible,
"percent": obj.percent,
"type": obj.aggregation_name,
}
)
self.tracker_mock.emit.reset_mock()

0 comments on commit 329502f

Please sign in to comment.