Add methods for folding #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ok, this part is ready for review. |
nelsam
reviewed
Oct 14, 2019
| @@ -240,16 +242,26 @@ func (e *CodeEditor) KeyStroke(ev gxui.KeyStrokeEvent) (consume bool) { | |||
| // mixins.TextBox overrides | |||
| func (e *CodeEditor) CreateLine(theme gxui.Theme, index int) (TextBoxLine, gxui.Control) { | |||
| lineNumber := theme.CreateLabel() | |||
| lineNumber.SetText(fmt.Sprintf("%.4d", index+1)) // Displayed lines start at 1 | |||
| lineNumber.SetText(fmt.Sprintf("%4d", index+1)) // Displayed lines start at 1 | |||
There was a problem hiding this comment.
Did you intend to change this from %.4d to %4d?
There was a problem hiding this comment.
I just realized, the old code is bugged. In fact, vidar overrides this to get its line numbers.
lgtm.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For code folding issue.
I opened PR in its current form because I'm not sure whether it makes sense to continue
work on this issue or to do something more needfull/simple. Of course, the main part is still ahead(binding to brackets, edit processing, nesting,...), but all this should be done on the editor's side, not the library.
This is WIP because at the library level need to add at least improve processing displaying
the scrollbar in consideration of the total number of hidden items.
ToDo