DO NOT MERGE Ensure BPD is available in execute() #449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ampaze
reviewed
Aug 6, 2024
lib/Fhp/FinTs.php
Outdated
| @@ -282,7 +282,7 @@ public function execute(BaseAction $action) | |||
| throw new \RuntimeException('Need to login (DialogInitialization) before executing other actions'); | |||
| } | |||
|
|
|||
| $requestSegments = $action->getNextRequest($this->bpd, $this->upd); | |||
| $requestSegments = $action->getNextRequest($this->getBpd(), $this->upd); | |||
There was a problem hiding this comment.
Imho muss schon die Prüfung if ($action instanceof PaginateableAction) vorhanden sein, es soll ja gerade bei nicht paginierten Antworten ohne BPD funktionieren.
There was a problem hiding this comment.
Oh ja stimmt. Habe es auf deinen ursprünglichen Vorschlag zurück geändert.
Should not merge this because of https://github.com/nemiah/phpFinTS/blob/4bd1cecf823aaa506e216131146b2a6c7304be9e/lib/Fhp/FinTs.php#L631-L633 and because I'm not sure this will work dialog-wise.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.