optimize DivRem #1173
Merged
optimize DivRem #1173
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Hecate2 please fix conflict |
Jim8y
reviewed
Sep 20, 2024
| methodConvert.Push(2); | ||
| methodConvert.AddInstruction(OpCode.PICK);// r, l, l, r | ||
| methodConvert.AddInstruction(OpCode.DIV); // r, l, l/r | ||
| // TODO: for types that is restricted by range, check l/r <= MaxValue |
There was a problem hiding this comment.
Are you going to work on this todo？
There was a problem hiding this comment.
No. I think we can just allow overflow.
There was a problem hiding this comment.
Will this be the same as C# behavior?
There was a problem hiding this comment.
No, but only when DivRem(int.MinValue, -1)
There was a problem hiding this comment.
then can you please explain this as comment where others can learn.
There was a problem hiding this comment.
then can you please explain this as comment where others can learn.
Done
…to fix-divRem # Conflicts: # tests/Neo.Compiler.CSharp.UnitTests/TestingArtifacts/Contract_Integer.cs
shargon
approved these changes
Sep 22, 2024
Jim8y
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using MOD instead of l-l/r*r
Original implementation check and throw when the remainder overflows. However it is impossible for the remainder to overflow, because
Therefore I cancelled the check.
But it is possible for the quotient to overflow in a single case, when the allowed range is [-128, 127] and I call DivRem(-128, -1). I did not check and throw in this case, because it is rare and expensive, and the original implementation did not check it.