add ut for property #1233
add ut for property #1233
Conversation
|
My fault, not applying |
fix non-static field get and set
|
Ut fault |
Because of calling ++ on null |
I am debugging this, but without a proper tool, it is very hard to locate where the opcode is being processed in the compiler, very hard to debug. |
|
Will be hard to tackle. Smart contract _initialize only handles static constructors, and ignores non-static initial values. |
initialize with 0; need instance constructor if non-static field exists
|
Should be ready for merge |
| .ToArray(); | ||
|
|
||
| // Process each field using its symbol | ||
| ContractFields.ForEach(f => AddStaticField(f.Field)); |
There was a problem hiding this comment.
| ContractFields.ForEach(f => AddStaticField(f.Field)); | |
| foreach ((IFieldSymbol f, _) in ContractFields) | |
| AddStaticField(f); |
There was a problem hiding this comment.
array.ForEach is using Akka.Util.Internal, and is harder to debug
| @@ -29,6 +29,7 @@ | |||
| using System.Linq; | |||
| using System.Runtime.CompilerServices; | |||
| using System.Text; | |||
| using Akka.Util.Internal; | |||
There was a problem hiding this comment.
| using Akka.Util.Internal; |
| { | ||
| if(_context.ContractFields.Any(f => | ||
| SymbolEqualityComparer.Default.Equals(f.Field, field)) && | ||
| (field.Type.GetStackItemType() == StackItemType.Integer || field.Type.GetStackItemType() == StackItemType.Integer)) |
|
If we apply the methodology in d552e2e , we try to convert all non-static fields (in a class that directly inherit SmartContract) to static. This can bring trouble when we read the non-static fields, and we will need to change many codes related to IFieldSymbol and IdentifierNameSyntax. |
this pr adds ut to property to demonstrate that property actually does not work correctly.