Skip to content

Fix write-in-try analyzer for local storage syscalls #1393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: dev
Choose a base branch
from
Open

Fix write-in-try analyzer for local storage syscalls #1393

wants to merge 3 commits into from

Conversation

Jim8y
Copy link
Contributor

@Jim8y Jim8y commented Sep 23, 2025

Summary

  • allow WriteInTryAnalyzer to flag System.Storage.Local.* writes by reusing a shared syscall hash list
  • stabilise TryCatchFinallyCoverage so nested finally blocks preserve the try stack
  • add a regression unit test that ensures local storage syscalls are surfaced as vulnerabilities

Testing

  • dotnet test tests/Neo.Compiler.CSharp.UnitTests --filter WriteInTry

@Jim8y Jim8y force-pushed the fix-write-in-try-local-storage branch from 0cd7dd5 to e709898 Compare September 23, 2025 02:47
@Jim8y Jim8y force-pushed the fix-write-in-try-local-storage branch from e709898 to 6055a52 Compare September 23, 2025 02:52
@ajara87
Copy link
Member

ajara87 commented Sep 26, 2025

@Jim8y tests are failing. Could you check it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shargon shargon shargon approved these changes

@Wi1l-B0t Wi1l-B0t Wi1l-B0t approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Jim8y @ajara87 @shargon @Wi1l-B0t