Remove: remove System.Math #851
Conversation
|
I don't understand why |
|
why support math when you have to convert everything to a integer ( |
improper convert will have exceptions, no overflow will happen. |
Cause you will have two Math in the system, one with Pow, another doesnt. With Neo.Math, it is precisely clear what is supported by neo, what is not, while using System.Math is a mass cause you can not only use double in the smart contract, you dont know what methods are supported, what are not. |
|
Hey shargon, I still insist removing the system Math, otherwise you will have to deal with the System.Math's double types in contract. I can ban the use of System.Math with contract analyzer, and help developers to directly use Neo.Math instead of System.Math. |
* master: (28 commits) Reduce notifications (neo-project#888) Core optimize optimizer (neo-project#887) print-stack (neo-project#873) ZipArchive use utf8; simplify GetOperandString [Compiler] move expressions out of convert file. (neo-project#882) misc refactor Zip and Unzip methods for files only add optimize test add debug notify into contract (neo-project#872) [Compiler: Add]verify the NEP11 and NEP17 standards while compile them. (neo-project#881) [Compiler: Comment] add comment to initial value (neo-project#880) refactor move to folder `Optimizer` optimizer to remove unused instructions [Framework: Add] Define Standard Enum (neo-project#877) Fix: Fix dependency (neo-project#876) create seperate test contracts (neo-project#868) fix-nep11token (neo-project#874) add comments to statements (neo-project#875) move neo-core projects into a dependency folder to make it clear. (neo-project#871) ... # Conflicts: # src/Neo.Compiler.CSharp/MethodConvert.cs
This pr follows #836